From 9e8ea567c838574a0f14538c0bbbd83c3215aa55 Mon Sep 17 00:00:00 2001 From: Tim King Date: Mon, 26 Aug 2024 15:49:09 -0700 Subject: cmd/compile/internal/noder: write V2 bitstream aliastypeparams=1 Enables V2 unified IR bitstreams when GOEXPERIMENT aliastypeparams are enabled. Allows pkgbits.NewPkgEncoder to set the output version. Reenables support for writing V0 streams. Updates #68778 Updates #68526 Change-Id: I590c494d81ab7db148232ceaba52229068d1e986 Reviewed-on: https://go-review.googlesource.com/c/go/+/608595 Reviewed-by: David Chase LUCI-TryBot-Result: Go LUCI Reviewed-by: Cuong Manh Le --- src/internal/pkgbits/pkgbits_test.go | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) (limited to 'src/internal/pkgbits/pkgbits_test.go') diff --git a/src/internal/pkgbits/pkgbits_test.go b/src/internal/pkgbits/pkgbits_test.go index f4c3719446..6f4004741b 100644 --- a/src/internal/pkgbits/pkgbits_test.go +++ b/src/internal/pkgbits/pkgbits_test.go @@ -11,19 +11,25 @@ import ( ) func TestRoundTrip(t *testing.T) { - pw := pkgbits.NewPkgEncoder(-1) - w := pw.NewEncoder(pkgbits.RelocMeta, pkgbits.SyncPublic) - w.Flush() + for _, version := range []pkgbits.Version{ + pkgbits.V0, + pkgbits.V1, + pkgbits.V2, + } { + pw := pkgbits.NewPkgEncoder(version, -1) + w := pw.NewEncoder(pkgbits.RelocMeta, pkgbits.SyncPublic) + w.Flush() - var b strings.Builder - _ = pw.DumpTo(&b) - input := b.String() + var b strings.Builder + _ = pw.DumpTo(&b) + input := b.String() - pr := pkgbits.NewPkgDecoder("package_id", input) - r := pr.NewDecoder(pkgbits.RelocMeta, pkgbits.PublicRootIdx, pkgbits.SyncPublic) + pr := pkgbits.NewPkgDecoder("package_id", input) + r := pr.NewDecoder(pkgbits.RelocMeta, pkgbits.PublicRootIdx, pkgbits.SyncPublic) - if r.Version() != w.Version() { - t.Errorf("Expected reader version %q to be the writer version %q", r.Version(), w.Version()) + if r.Version() != w.Version() { + t.Errorf("Expected reader version %q to be the writer version %q", r.Version(), w.Version()) + } } } -- cgit v1.3