From 0bf1f02ed921ec2f78b27f133e7a688d3e8fa82e Mon Sep 17 00:00:00 2001 From: LE Manh Cuong Date: Sun, 5 May 2019 23:20:26 +0700 Subject: errors: fix Is panics if target is uncomparable Fixes #31841 Change-Id: I3f068686154fd2fa5755b0df47b4eaa5c9a19107 Reviewed-on: https://go-review.googlesource.com/c/go/+/175260 Reviewed-by: Damien Neil Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/errors/wrap.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/errors/wrap.go') diff --git a/src/errors/wrap.go b/src/errors/wrap.go index 04ddf79ba3..69dd9464ec 100644 --- a/src/errors/wrap.go +++ b/src/errors/wrap.go @@ -51,8 +51,10 @@ func Is(err, target error) bool { if target == nil { return err == target } + + isComparable := target == nil || reflectlite.TypeOf(target).Comparable() for { - if err == target { + if isComparable && err == target { return true } if x, ok := err.(interface{ Is(error) bool }); ok && x.Is(target) { -- cgit v1.3-5-g9baa