From ab87db8b46fcd987f0d42ecdd03c149288bc9383 Mon Sep 17 00:00:00 2001 From: cuiweixie Date: Sun, 4 Sep 2022 17:44:30 +0800 Subject: encoding: use strings.Builder Change-Id: Ib07699df8ea41fd8d1bca8ad050859fac24623de Reviewed-on: https://go-review.googlesource.com/c/go/+/428258 Reviewed-by: Robert Griesemer Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot Run-TryBot: Ian Lance Taylor Auto-Submit: Ian Lance Taylor --- src/encoding/xml/marshal_test.go | 8 ++++---- src/encoding/xml/xml_test.go | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/encoding/xml') diff --git a/src/encoding/xml/marshal_test.go b/src/encoding/xml/marshal_test.go index 774793a6c5..f6bcc7fd30 100644 --- a/src/encoding/xml/marshal_test.go +++ b/src/encoding/xml/marshal_test.go @@ -1894,13 +1894,13 @@ func TestMarshalWriteIOErrors(t *testing.T) { } func TestMarshalFlush(t *testing.T) { - var buf bytes.Buffer + var buf strings.Builder enc := NewEncoder(&buf) if err := enc.EncodeToken(CharData("hello world")); err != nil { t.Fatalf("enc.EncodeToken: %v", err) } if buf.Len() > 0 { - t.Fatalf("enc.EncodeToken caused actual write: %q", buf.Bytes()) + t.Fatalf("enc.EncodeToken caused actual write: %q", buf.String()) } if err := enc.Flush(); err != nil { t.Fatalf("enc.Flush: %v", err) @@ -2317,7 +2317,7 @@ var encodeTokenTests = []struct { func TestEncodeToken(t *testing.T) { loop: for i, tt := range encodeTokenTests { - var buf bytes.Buffer + var buf strings.Builder enc := NewEncoder(&buf) var err error for j, tok := range tt.toks { @@ -2437,7 +2437,7 @@ func TestIsValidDirective(t *testing.T) { // Issue 11719. EncodeToken used to silently eat tokens with an invalid type. func TestSimpleUseOfEncodeToken(t *testing.T) { - var buf bytes.Buffer + var buf strings.Builder enc := NewEncoder(&buf) if err := enc.EncodeToken(&StartElement{Name: Name{"", "object1"}}); err == nil { t.Errorf("enc.EncodeToken: pointer type should be rejected") diff --git a/src/encoding/xml/xml_test.go b/src/encoding/xml/xml_test.go index 8f0d97b6a6..7266b8fc99 100644 --- a/src/encoding/xml/xml_test.go +++ b/src/encoding/xml/xml_test.go @@ -894,7 +894,7 @@ func TestEscapeTextInvalidChar(t *testing.T) { input := []byte("A \x00 terminated string.") expected := "A \uFFFD terminated string." - buff := new(bytes.Buffer) + buff := new(strings.Builder) if err := EscapeText(buff, input); err != nil { t.Fatalf("have %v, want nil", err) } -- cgit v1.3