From 9965e4022030f56fc241be8934d5e6b95ac84900 Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Fri, 17 Oct 2014 12:37:41 -0700 Subject: encoding/gob: custom array/slice decoders Use go generate to write better loops for decoding arrays, just as we did for encoding. It doesn't help as much, relatively speaking, but it's still noticeable. benchmark old ns/op new ns/op delta BenchmarkDecodeComplex128Slice 202348 184529 -8.81% BenchmarkDecodeFloat64Slice 135800 120979 -10.91% BenchmarkDecodeInt32Slice 121200 105149 -13.24% BenchmarkDecodeStringSlice 288129 278214 -3.44% LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/154420044 --- src/encoding/gob/encode.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/encoding/gob/encode.go') diff --git a/src/encoding/gob/encode.go b/src/encoding/gob/encode.go index 3b8d0b4271..3da848c851 100644 --- a/src/encoding/gob/encode.go +++ b/src/encoding/gob/encode.go @@ -508,7 +508,7 @@ func encOpFor(rt reflect.Type, inProgress map[reflect.Type]*encOp, building map[ } // Slices have a header; we decode it to find the underlying array. elemOp, elemIndir := encOpFor(t.Elem(), inProgress, building) - helper := sliceHelper[t.Elem().Kind()] + helper := encSliceHelper[t.Elem().Kind()] op = func(i *encInstr, state *encoderState, slice reflect.Value) { if !state.sendZero && slice.Len() == 0 { return @@ -519,7 +519,7 @@ func encOpFor(rt reflect.Type, inProgress map[reflect.Type]*encOp, building map[ case reflect.Array: // True arrays have size in the type. elemOp, elemIndir := encOpFor(t.Elem(), inProgress, building) - helper := arrayHelper[t.Elem().Kind()] + helper := encArrayHelper[t.Elem().Kind()] op = func(i *encInstr, state *encoderState, array reflect.Value) { state.update(i) state.enc.encodeArray(state.b, array, *elemOp, elemIndir, array.Len(), helper) -- cgit v1.3-5-g9baa