From 9fbc06e6aa88372a449b75b35420e83ffce05a0b Mon Sep 17 00:00:00 2001 From: Justin Nuß Date: Wed, 2 Aug 2017 19:46:41 +0200 Subject: encoding/csv: preserve \r\n in quoted fields The parser mistakenly assumed it could always fold \r\n into \n, which is not true since a \r\n inside a quoted fields has no special meaning and should be kept as is. Fix this by not folding \r\n to \n inside quotes fields. Fixes #21201 Change-Id: Ifebc302e49cf63e0a027ee90f088dbc050a2b7a6 Reviewed-on: https://go-review.googlesource.com/52810 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot --- src/encoding/csv/reader_test.go | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src/encoding/csv/reader_test.go') diff --git a/src/encoding/csv/reader_test.go b/src/encoding/csv/reader_test.go index 76e94bab3e..3811629aad 100644 --- a/src/encoding/csv/reader_test.go +++ b/src/encoding/csv/reader_test.go @@ -284,6 +284,13 @@ x,,, Line: 2, Column: 2, }, + { // issue 21201 + Name: "CRLFInQuotedField", + Input: "\"Hello\r\nHi\"", + Output: [][]string{ + {"Hello\r\nHi"}, + }, + }, } func TestRead(t *testing.T) { -- cgit v1.3