From 3b92f36d15c868e856be71c0fadfc7ff97039b96 Mon Sep 17 00:00:00 2001 From: Prashant Agrawal Date: Fri, 17 May 2019 17:55:20 -0700 Subject: debug/pe: enable parsing of variable length optional header in PE file The debug/pe package assumes there are always 16 entries in DataDirectory in OptionalHeader32/64 ref pe.go: ... NumberOfRvaAndSizes uint32 DataDirectory [16]DataDirectory } ... But that is not always the case, there could be less no of entries (PE signed linux kernel for example): $ sudo pev /boot/vmlinuz-4.15.0-47-generic .... Data-dictionary entries: 6 .... In such case, the parsing gives incorrect results. This changes aims to fix that by: 1. Determining type of optional header by looking at header magic instead of size 2. Parsing optional header in 2 steps: a. Fixed part b. Variable data directories part Testing: 1. Fixed existing test cases to reflect the change 2. Added new file (modified linux kernel image) which has smaller number of data directories Fixes #32126 Change-Id: Iee56ecc4369a0e75a4be805e7cb8555c7d81ae2f Reviewed-on: https://go-review.googlesource.com/c/go/+/177959 Run-TryBot: Alex Brainman TryBot-Result: Gobot Gobot Reviewed-by: Alex Brainman --- src/debug/pe/testdata/vmlinuz-4.15.0-47-generic | Bin 0 -> 474 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 src/debug/pe/testdata/vmlinuz-4.15.0-47-generic (limited to 'src/debug/pe/testdata') diff --git a/src/debug/pe/testdata/vmlinuz-4.15.0-47-generic b/src/debug/pe/testdata/vmlinuz-4.15.0-47-generic new file mode 100644 index 0000000000..d01cf61d05 Binary files /dev/null and b/src/debug/pe/testdata/vmlinuz-4.15.0-47-generic differ -- cgit v1.3