From abfbc0555bdef683d916dd97c1fb353c6d08bee6 Mon Sep 17 00:00:00 2001 From: Andrew Date: Wed, 20 Nov 2019 12:06:51 -0500 Subject: [release-branch.go1.13] all: base64-encode binaries that will cause Apple notarization to fail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Starting with macOS 10.15 (Catalina), Apple now requires all software distributed outside of the App Store to be notarized. Any binaries we distribute must abide by a strict set of requirements like code-signing and having a minimum target SDK of 10.9 (amongst others). Apple’s notarization service will recursively inspect archives looking to find notarization candidate binaries. If it finds a binary that does not meet the requirements or is unable to decompress an archive, it will reject the entire distribution. From cursory testing, it seems that the service uses content sniffing to determine file types, so changing the file extension will not work. There are some binaries and archives included in our distribution that are being detected by Apple’s service as potential candidates for notarization or decompression. As these are files used by tests and some are intentionally invalid, we don’t intend to ever make them compliant. As a workaround for this, we base64-encode any binaries or archives that Apple’s notarization service issues a warning for, as these warnings will become errors in January 2020. Updates #34986 Fixes #35748 Change-Id: I106fbb6227b61eb221755568f047ee11103c1680 Reviewed-on: https://go-review.googlesource.com/c/go/+/208118 Run-TryBot: Andrew Bonventre TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick (cherry picked from commit 8bbfc51d9ac9ce9472e126cc3654c9a45eceb236) Reviewed-on: https://go-review.googlesource.com/c/go/+/208219 Reviewed-by: Alexander Rakoczy --- src/debug/macho/testdata/gcc-amd64-darwin-exec-debug | Bin 4540 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 src/debug/macho/testdata/gcc-amd64-darwin-exec-debug (limited to 'src/debug/macho/testdata/gcc-amd64-darwin-exec-debug') diff --git a/src/debug/macho/testdata/gcc-amd64-darwin-exec-debug b/src/debug/macho/testdata/gcc-amd64-darwin-exec-debug deleted file mode 100644 index a47d3aef78..0000000000 Binary files a/src/debug/macho/testdata/gcc-amd64-darwin-exec-debug and /dev/null differ -- cgit v1.3