From f376b8510ed7884c69a09fbcf61418f7285f2787 Mon Sep 17 00:00:00 2001 From: Emmanuel T Odeke Date: Thu, 2 Jan 2020 02:00:55 -0800 Subject: all: fix invalid invocations of Fatalf in goroutines Found by running the go vet pass 'testinggoroutine' that I started in CL 212920. Change-Id: Ic9462fac85dbafc437fe4a323b886755a67a1efa Reviewed-on: https://go-review.googlesource.com/c/go/+/213097 Run-TryBot: Emmanuel Odeke TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- src/database/sql/sql_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/database/sql') diff --git a/src/database/sql/sql_test.go b/src/database/sql/sql_test.go index ed0099e0e9..6f59260cda 100644 --- a/src/database/sql/sql_test.go +++ b/src/database/sql/sql_test.go @@ -629,7 +629,8 @@ func TestPoolExhaustOnCancel(t *testing.T) { go func() { rows, err := db.Query("SELECT|people|name,photo|") if err != nil { - t.Fatalf("Query: %v", err) + t.Errorf("Query: %v", err) + return } rows.Close() saturateDone.Done() @@ -637,6 +638,9 @@ func TestPoolExhaustOnCancel(t *testing.T) { } saturate.Wait() + if t.Failed() { + t.FailNow() + } state = 2 // Now cancel the request while it is waiting. -- cgit v1.3