From dec95d8fad2e1b3dea3fa1472cc21542c40236ce Mon Sep 17 00:00:00 2001 From: Daniel Theophanes Date: Fri, 7 Apr 2017 12:21:50 -0700 Subject: database/sql: correctly guard the query Row preventing early release When a Tx starts a query, prevent returning the connection to the pool until after the query finishes. Fixes #19058 Change-Id: I2c0480d9cca9eeb173b5b3441a5aeed6f527e0ac Reviewed-on: https://go-review.googlesource.com/40400 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/database/sql/sql_test.go | 1 - 1 file changed, 1 deletion(-) (limited to 'src/database/sql/sql_test.go') diff --git a/src/database/sql/sql_test.go b/src/database/sql/sql_test.go index f511aa4ac3..b5a1f850bd 100644 --- a/src/database/sql/sql_test.go +++ b/src/database/sql/sql_test.go @@ -2997,7 +2997,6 @@ func TestIssue18719(t *testing.T) { // canceled context. cancel() - waitForRowsClose(t, rows, 5*time.Second) } func TestConcurrency(t *testing.T) { -- cgit v1.3