From 05cbbf985fed823a174bf95cc78a7d44f948fdab Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Wed, 22 May 2024 15:03:13 -0400 Subject: all: document legacy //go:linkname for modules with ≥500 dependents MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For #67401. Change-Id: I7dd28c3b01a1a647f84929d15412aa43ab0089ee Reviewed-on: https://go-review.googlesource.com/c/go/+/587575 Reviewed-by: Cherry Mui Auto-Submit: Russ Cox LUCI-TryBot-Result: Go LUCI --- src/database/sql/sql.go | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) (limited to 'src/database/sql/sql.go') diff --git a/src/database/sql/sql.go b/src/database/sql/sql.go index 9373aa1c58..de774a0510 100644 --- a/src/database/sql/sql.go +++ b/src/database/sql/sql.go @@ -29,12 +29,22 @@ import ( "sync" "sync/atomic" "time" + _ "unsafe" ) -var ( - driversMu sync.RWMutex - drivers = make(map[string]driver.Driver) -) +var driversMu sync.RWMutex + +// drivers should be an internal detail, +// but widely used packages access it using linkname. +// (It is extra wrong that they linkname drivers but not driversMu.) +// Notable members of the hall of shame include: +// - github.com/instana/go-sensor +// +// Do not remove or change the type signature. +// See go.dev/issue/67401. +// +//go:linkname drivers +var drivers = make(map[string]driver.Driver) // nowFunc returns the current time; it's overridden in tests. var nowFunc = time.Now -- cgit v1.3