From 29057b707d468bd690e6eadfebe89c4ff737867c Mon Sep 17 00:00:00 2001 From: Jinzhu Date: Thu, 19 May 2022 02:44:00 +0000 Subject: database/sql: fix close rows error ignored in Next Change-Id: I19f0d764e2a6122307f3f26a6dd3be7b1155c73b GitHub-Last-Rev: 9f1f883c452201679a2d2af2cc29de0f09a43f28 GitHub-Pull-Request: golang/go#52756 Reviewed-on: https://go-review.googlesource.com/c/go/+/404794 Reviewed-by: Daniel Theophanes Reviewed-by: Bryan Mills Reviewed-by: Michael Knyszek Run-TryBot: Daniel Theophanes TryBot-Result: Gopher Robot --- src/database/sql/fakedb_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/database/sql/fakedb_test.go') diff --git a/src/database/sql/fakedb_test.go b/src/database/sql/fakedb_test.go index ec47ce4714..2fe5ea42da 100644 --- a/src/database/sql/fakedb_test.go +++ b/src/database/sql/fakedb_test.go @@ -1089,6 +1089,9 @@ type rowsCursor struct { // This is separate from the fakeConn.line to allow for drivers that // can start multiple queries on the same transaction at the same time. line int64 + + // closeErr is returned when rowsCursor.Close + closeErr error } func (rc *rowsCursor) touchMem() { @@ -1100,7 +1103,7 @@ func (rc *rowsCursor) Close() error { rc.touchMem() rc.parentMem.touchMem() rc.closed = true - return nil + return rc.closeErr } func (rc *rowsCursor) Columns() []string { -- cgit v1.3-5-g9baa