From b5aefe07e5afe2fd5d49c6a4219cc826b3e4e34e Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 14 Oct 2025 11:40:26 +0200 Subject: all: remove unnecessary loop variable copies in tests Copying the loop variable is no longer necessary since Go 1.22. Change-Id: Iebb21dac44a20ec200567f1d786f105a4ee4999d Reviewed-on: https://go-review.googlesource.com/c/go/+/711640 Reviewed-by: Florian Lehner Auto-Submit: Damien Neil Reviewed-by: Dmitri Shuralyov Reviewed-by: Damien Neil Auto-Submit: Tobias Klauser LUCI-TryBot-Result: Go LUCI --- src/crypto/cipher/ctr_aes_test.go | 6 ------ src/crypto/rsa/rsa_test.go | 1 - src/crypto/tls/handshake_client_test.go | 1 - src/crypto/tls/tls_test.go | 1 - src/crypto/x509/platform_test.go | 1 - 5 files changed, 10 deletions(-) (limited to 'src/crypto') diff --git a/src/crypto/cipher/ctr_aes_test.go b/src/crypto/cipher/ctr_aes_test.go index 3394246778..9b7d30e216 100644 --- a/src/crypto/cipher/ctr_aes_test.go +++ b/src/crypto/cipher/ctr_aes_test.go @@ -145,7 +145,6 @@ func TestCTR_AES_multiblock_random_IV(t *testing.T) { const Size = 100 for _, keySize := range []int{16, 24, 32} { - keySize := keySize t.Run(fmt.Sprintf("keySize=%d", keySize), func(t *testing.T) { key := randBytes(t, r, keySize) aesBlock, err := aes.NewCipher(key) @@ -164,10 +163,8 @@ func TestCTR_AES_multiblock_random_IV(t *testing.T) { // individually using multiblock implementation to catch edge cases. for part1 := 0; part1 <= Size; part1++ { - part1 := part1 t.Run(fmt.Sprintf("part1=%d", part1), func(t *testing.T) { for part2 := 0; part2 <= Size-part1; part2++ { - part2 := part2 t.Run(fmt.Sprintf("part2=%d", part2), func(t *testing.T) { _, multiblockCtr := makeTestingCiphers(aesBlock, iv) multiblockCiphertext := make([]byte, len(plaintext)) @@ -216,7 +213,6 @@ func TestCTR_AES_multiblock_overflow_IV(t *testing.T) { } for _, keySize := range []int{16, 24, 32} { - keySize := keySize t.Run(fmt.Sprintf("keySize=%d", keySize), func(t *testing.T) { for _, iv := range ivs { key := randBytes(t, r, keySize) @@ -227,7 +223,6 @@ func TestCTR_AES_multiblock_overflow_IV(t *testing.T) { t.Run(fmt.Sprintf("iv=%s", hex.EncodeToString(iv)), func(t *testing.T) { for _, offset := range []int{0, 1, 16, 1024} { - offset := offset t.Run(fmt.Sprintf("offset=%d", offset), func(t *testing.T) { genericCtr, multiblockCtr := makeTestingCiphers(aesBlock, iv) @@ -260,7 +255,6 @@ func TestCTR_AES_multiblock_XORKeyStreamAt(t *testing.T) { plaintext := randBytes(t, r, Size) for _, keySize := range []int{16, 24, 32} { - keySize := keySize t.Run(fmt.Sprintf("keySize=%d", keySize), func(t *testing.T) { key := randBytes(t, r, keySize) iv := randBytes(t, r, aesBlockSize) diff --git a/src/crypto/rsa/rsa_test.go b/src/crypto/rsa/rsa_test.go index 0d5b6e08f0..b9e85bd8ff 100644 --- a/src/crypto/rsa/rsa_test.go +++ b/src/crypto/rsa/rsa_test.go @@ -212,7 +212,6 @@ func TestEverything(t *testing.T) { max = 2048 } for size := min; size <= max; size++ { - size := size t.Run(fmt.Sprintf("%d", size), func(t *testing.T) { t.Parallel() priv, err := GenerateKey(rand.Reader, size) diff --git a/src/crypto/tls/handshake_client_test.go b/src/crypto/tls/handshake_client_test.go index 9c94016f13..6020c0f055 100644 --- a/src/crypto/tls/handshake_client_test.go +++ b/src/crypto/tls/handshake_client_test.go @@ -2693,7 +2693,6 @@ func TestTLS13OnlyClientHelloCipherSuite(t *testing.T) { }, } for _, tt := range tls13Tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() testTLS13OnlyClientHelloCipherSuite(t, tt.ciphers) diff --git a/src/crypto/tls/tls_test.go b/src/crypto/tls/tls_test.go index bfcc62ccfb..6539009df6 100644 --- a/src/crypto/tls/tls_test.go +++ b/src/crypto/tls/tls_test.go @@ -1880,7 +1880,6 @@ func testVerifyCertificates(t *testing.T, version uint16) { rootCAs.AddCert(issuer) for _, test := range tests { - test := test t.Run(test.name, func(t *testing.T) { t.Parallel() diff --git a/src/crypto/x509/platform_test.go b/src/crypto/x509/platform_test.go index b425e02f3b..44ceff43f4 100644 --- a/src/crypto/x509/platform_test.go +++ b/src/crypto/x509/platform_test.go @@ -202,7 +202,6 @@ func TestPlatformVerifier(t *testing.T) { } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() parent := testRoot -- cgit v1.3