From c50c6bbc030ea170320f438c3f328fa475e87e2b Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Tue, 7 Jun 2022 09:22:32 +0700 Subject: [dev.unified] cmd/compile: set base.Pos when process assignDef in Unified IR CL 410343 changes Unified IR to visit LHS before RHS/X in assign/for statement. Thus, it needs to set base.Pos before processing assignee expression, so invalid type can be reported with correct position. Updates #53058 Change-Id: Ic9f60cbf35c8bd71cb391e806396572c37811af7 Reviewed-on: https://go-review.googlesource.com/c/go/+/410794 Reviewed-by: Cherry Mui Run-TryBot: Cuong Manh Le Reviewed-by: Keith Randall Reviewed-by: Keith Randall TryBot-Result: Gopher Robot --- src/cmd/compile/internal/noder/reader.go | 1 + 1 file changed, 1 insertion(+) (limited to 'src/cmd') diff --git a/src/cmd/compile/internal/noder/reader.go b/src/cmd/compile/internal/noder/reader.go index d050275f9e..3cd6ec5668 100644 --- a/src/cmd/compile/internal/noder/reader.go +++ b/src/cmd/compile/internal/noder/reader.go @@ -1338,6 +1338,7 @@ func (r *reader) assign() (ir.Node, bool) { case assignDef: pos := r.pos() + setBasePos(pos) _, sym := r.localIdent() typ := r.typ() -- cgit v1.3-5-g9baa