From d12fe60004ae5e4024c8a93f4f7de7183bb61576 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 1 Mar 2023 13:45:18 +0000 Subject: all: skip tests that fail on android/arm64 Many of the tests skipped platforms that build PIE binaries by default, but (still) lack a central function to report which platforms those are. Some of the tests assumed (but did not check for) internal linking support, or invoked `go tool link` directly without properly configuring the external linker. A few of the tests seem to be triggering latent bugs in the linker. For #58806. For #58807. For #58794. Change-Id: Ie4d06b1597f404590ad2abf978d4c363647407ac Reviewed-on: https://go-review.googlesource.com/c/go/+/472455 Reviewed-by: Cherry Mui Auto-Submit: Bryan Mills Run-TryBot: Bryan Mills TryBot-Result: Gopher Robot --- src/cmd/pack/pack_test.go | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/cmd/pack') diff --git a/src/cmd/pack/pack_test.go b/src/cmd/pack/pack_test.go index 5534a10b37..309139aa4d 100644 --- a/src/cmd/pack/pack_test.go +++ b/src/cmd/pack/pack_test.go @@ -13,6 +13,7 @@ import ( "io/fs" "os" "path/filepath" + "runtime" "strings" "sync" "testing" @@ -191,6 +192,7 @@ func TestExtract(t *testing.T) { // Test that pack-created archives can be understood by the tools. func TestHello(t *testing.T) { testenv.MustHaveGoBuild(t) + testenv.MustInternalLink(t, false) dir := t.TempDir() hello := filepath.Join(dir, "hello.go") @@ -413,6 +415,9 @@ func doRun(t *testing.T, dir string, args ...string) string { cmd.Dir = dir out, err := cmd.CombinedOutput() if err != nil { + if t.Name() == "TestHello" && runtime.GOOS == "android" && runtime.GOARCH == "arm64" { + testenv.SkipFlaky(t, 58806) + } t.Fatalf("%v: %v\n%s", args, err, string(out)) } return string(out) -- cgit v1.3-5-g9baa