From 7bc3e5880675ce4aae245f46d193924cff5efdfb Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Fri, 5 Jun 2015 11:01:53 -0400 Subject: all: extract "can I exec?" check from tests into internal/testenv Change-Id: I7b54be9d8b50b39e01c6be21f310ae9a10404e9d Reviewed-on: https://go-review.googlesource.com/10753 Reviewed-by: Brad Fitzpatrick Reviewed-by: David Crawshaw Reviewed-by: Ian Lance Taylor --- src/cmd/objdump/objdump_test.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) (limited to 'src/cmd/objdump') diff --git a/src/cmd/objdump/objdump_test.go b/src/cmd/objdump/objdump_test.go index 9bd71495af..54e26552e0 100644 --- a/src/cmd/objdump/objdump_test.go +++ b/src/cmd/objdump/objdump_test.go @@ -5,6 +5,7 @@ package main import ( + "internal/testenv" "io/ioutil" "os" "os/exec" @@ -15,15 +16,7 @@ import ( ) func buildObjdump(t *testing.T) (tmp, exe string) { - switch runtime.GOOS { - case "android", "nacl": - t.Skipf("skipping on %s", runtime.GOOS) - case "darwin": - switch runtime.GOARCH { - case "arm", "arm64": - t.Skipf("skipping on %s/%s, cannot fork", runtime.GOOS, runtime.GOARCH) - } - } + testenv.MustHaveGoBuild(t) tmp, err := ioutil.TempDir("", "TestObjDump") if err != nil { -- cgit v1.3-5-g9baa