From 8bd803fd4ea3a549a9124f5a4e18af9596ef35df Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Tue, 4 Oct 2022 09:00:31 -0400 Subject: cmd/internal/sys: migrate support.go functions to new internal pkg Separate out the functions from cmd/internal/sys/support.go and migrate them to a new package internal/platform, so that functions such as "RaceDetectorSupported" can be called from tests in std as well as in cmd. This isn't a complete move of everything in cmd/internal/sys; there are still many functions left. The original version of this CL (patch set 1) called the new package "internal/sys", but for packages that needed both "internal/sys" and "cmd/internal/sys" the import of the former had to be done with a different name, which was confusing and also required a hack in cmd/dist. Updates #56006. Change-Id: I866d62e75adbf3a640a06e2c7386a6e9e2a18d91 Reviewed-on: https://go-review.googlesource.com/c/go/+/438475 Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot Reviewed-by: Cherry Mui Run-TryBot: Than McIntosh --- src/cmd/link/link_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/cmd/link/link_test.go') diff --git a/src/cmd/link/link_test.go b/src/cmd/link/link_test.go index c1a30363cb..35babe61fc 100644 --- a/src/cmd/link/link_test.go +++ b/src/cmd/link/link_test.go @@ -9,6 +9,7 @@ import ( "bytes" "debug/macho" "internal/buildcfg" + "internal/platform" "internal/testenv" "os" "os/exec" @@ -17,8 +18,6 @@ import ( "runtime" "strings" "testing" - - "cmd/internal/sys" ) var AuthorPaidByTheColumnInch struct { @@ -976,7 +975,7 @@ func main() { func TestIssue42396(t *testing.T) { testenv.MustHaveGoBuild(t) - if !sys.RaceDetectorSupported(runtime.GOOS, runtime.GOARCH) { + if !platform.RaceDetectorSupported(runtime.GOOS, runtime.GOARCH) { t.Skip("no race detector support") } -- cgit v1.3