From 4aca8b00fffe2d228d6dc9d4d061148bb721efd4 Mon Sep 17 00:00:00 2001 From: Michael Hudson-Doyle Date: Fri, 28 Apr 2017 08:07:56 +1200 Subject: cmd/internal/objabi: shrink SymType down to a uint8 Now that it only takes small values. Change-Id: I08086d392529d8775b470d65afc2475f8d0e7f4a Reviewed-on: https://go-review.googlesource.com/42030 Run-TryBot: Michael Hudson-Doyle TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/internal/obj/objfile.go | 2 +- src/cmd/internal/objabi/symkind.go | 2 +- src/cmd/internal/objabi/symkind_string.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/cmd/internal') diff --git a/src/cmd/internal/obj/objfile.go b/src/cmd/internal/obj/objfile.go index b81d569348..2528064a82 100644 --- a/src/cmd/internal/obj/objfile.go +++ b/src/cmd/internal/obj/objfile.go @@ -283,7 +283,7 @@ func (w *objWriter) writeSym(s *LSym) { } w.wr.WriteByte(symPrefix) - w.writeInt(int64(s.Type)) + w.wr.WriteByte(byte(s.Type)) w.writeRefIndex(s) flags := int64(0) if s.DuplicateOK() { diff --git a/src/cmd/internal/objabi/symkind.go b/src/cmd/internal/objabi/symkind.go index 6219436fb7..62a7efd964 100644 --- a/src/cmd/internal/objabi/symkind.go +++ b/src/cmd/internal/objabi/symkind.go @@ -31,7 +31,7 @@ package objabi // A SymKind describes the kind of memory represented by a symbol. -type SymKind int16 +type SymKind uint8 // Defined SymKind values. // diff --git a/src/cmd/internal/objabi/symkind_string.go b/src/cmd/internal/objabi/symkind_string.go index b28628b520..aabcfd2d54 100644 --- a/src/cmd/internal/objabi/symkind_string.go +++ b/src/cmd/internal/objabi/symkind_string.go @@ -9,7 +9,7 @@ const _SymKind_name = "SxxxSTEXTSRODATASNOPTRDATASDATASBSSSNOPTRBSSSTLSBSSSDWARF var _SymKind_index = [...]uint8{0, 4, 9, 16, 26, 31, 35, 44, 51, 61} func (i SymKind) String() string { - if i < 0 || i >= SymKind(len(_SymKind_index)-1) { + if i >= SymKind(len(_SymKind_index)-1) { return fmt.Sprintf("SymKind(%d)", i) } return _SymKind_name[_SymKind_index[i]:_SymKind_index[i+1]] -- cgit v1.3-5-g9baa