From 47d6423673479edc418e777d221f2527076e9944 Mon Sep 17 00:00:00 2001 From: Abhinav Gupta Date: Thu, 22 Feb 2024 21:00:46 -0800 Subject: cmd/go/internal/script: add fuzz test for quoteArgs Adds a fuzz test for quoteArgs and fixes the bugs it found: handling of empty strings and strings containing "&" or "$". This is a copy of a similar change submitted to rsc.io/script: https://github.com/rsc/script/pull/10 Change-Id: I76e7fc89475e1c4e415f45f2c7ac4a87a7a659e6 Reviewed-on: https://go-review.googlesource.com/c/go/+/566316 Reviewed-by: Michael Matloob Reviewed-by: Michael Matloob LUCI-TryBot-Result: Go LUCI Reviewed-by: David Chase --- src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/2abacd54f8b6b056 | 2 ++ src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/5838cdfae7b16cde | 2 ++ src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/e6019c3e89cc4df9 | 2 ++ 3 files changed, 6 insertions(+) create mode 100644 src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/2abacd54f8b6b056 create mode 100644 src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/5838cdfae7b16cde create mode 100644 src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/e6019c3e89cc4df9 (limited to 'src/cmd/internal/script/testdata') diff --git a/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/2abacd54f8b6b056 b/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/2abacd54f8b6b056 new file mode 100644 index 0000000000..8e2be246c5 --- /dev/null +++ b/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/2abacd54f8b6b056 @@ -0,0 +1,2 @@ +go test fuzz v1 +string("0\xa2$000") diff --git a/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/5838cdfae7b16cde b/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/5838cdfae7b16cde new file mode 100644 index 0000000000..64c3abaff8 --- /dev/null +++ b/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/5838cdfae7b16cde @@ -0,0 +1,2 @@ +go test fuzz v1 +string("") diff --git a/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/e6019c3e89cc4df9 b/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/e6019c3e89cc4df9 new file mode 100644 index 0000000000..67f8cfc58b --- /dev/null +++ b/src/cmd/internal/script/testdata/fuzz/FuzzQuoteArgs/e6019c3e89cc4df9 @@ -0,0 +1,2 @@ +go test fuzz v1 +string("&") -- cgit v1.3