From 733ba921875ea11088f1f447cbca418f651aae5c Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Tue, 3 Jan 2023 13:11:10 -0500 Subject: cmd/compile: flag 'large' functions when -m=2+ in effect When -m=N (where N > 1) is in effect, include a note in the trace output if a given function is considered "big" during inlining analysis, since this causes the inliner to be less aggressive. If a small change to a large function happens to nudge it over the large function threshold, it can be confusing for developers, thus it's probably worth including this info in the remark output. Change-Id: Id31a1b76371ab1ef9265ba28a377f97b0247d0a7 Reviewed-on: https://go-review.googlesource.com/c/go/+/460317 Reviewed-by: Keith Randall TryBot-Result: Gopher Robot Run-TryBot: Than McIntosh Reviewed-by: Keith Randall --- src/cmd/compile/internal/inline/inl.go | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/cmd/compile') diff --git a/src/cmd/compile/internal/inline/inl.go b/src/cmd/compile/internal/inline/inl.go index 8620db2adb..e3b2e44f61 100644 --- a/src/cmd/compile/internal/inline/inl.go +++ b/src/cmd/compile/internal/inline/inl.go @@ -742,6 +742,9 @@ func InlineCalls(fn *ir.Func, profile *pgo.Profile) { ir.CurFunc = fn maxCost := int32(inlineMaxBudget) if isBigFunc(fn) { + if base.Flag.LowerM > 1 { + fmt.Printf("%v: function %v considered 'big'; revising maxCost from %d to %d\n", ir.Line(fn), fn, maxCost, inlineBigFunctionMaxCost) + } maxCost = inlineBigFunctionMaxCost } var inlCalls []*ir.InlinedCallExpr -- cgit v1.3