From d1593b7a4a8cd60e30bfc41df83fb22ab8393d51 Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Sat, 19 Aug 2023 22:32:08 -0700 Subject: cmd/compile: do some TODOs about Fatalf Separate CL in case I'm mistaken. Change-Id: I6b5fa0efb27a6b4fb4c133698bd7e2f01b4cccdb Reviewed-on: https://go-review.googlesource.com/c/go/+/521195 TryBot-Result: Gopher Robot Reviewed-by: Austin Clements Auto-Submit: Matthew Dempsky Run-TryBot: Matthew Dempsky Reviewed-by: Cuong Manh Le --- src/cmd/compile/internal/devirtualize/devirtualize.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/cmd/compile/internal/devirtualize/devirtualize.go') diff --git a/src/cmd/compile/internal/devirtualize/devirtualize.go b/src/cmd/compile/internal/devirtualize/devirtualize.go index 93882a3496..ae9f24d9a5 100644 --- a/src/cmd/compile/internal/devirtualize/devirtualize.go +++ b/src/cmd/compile/internal/devirtualize/devirtualize.go @@ -129,11 +129,7 @@ func staticCall(call *ir.CallExpr) { call.SetOp(ir.OCALLINTER) call.X = x default: - // TODO(mdempsky): Turn back into Fatalf after more testing. - if base.Flag.LowerM != 0 { - base.WarnfAt(call.Pos(), "failed to devirtualize %v (%v)", x, x.Op()) - } - return + base.FatalfAt(call.Pos(), "failed to devirtualize %v (%v)", x, x.Op()) } // Duplicated logic from typecheck for function call return -- cgit v1.3