From 935ba2e486d035c60104217eec8f2a223cdb3bef Mon Sep 17 00:00:00 2001 From: apocelipes Date: Mon, 9 Mar 2026 17:32:42 +0000 Subject: bytes: remove unused indexBytePortable The function "indexBytePortable" is no longer in use, and we have an identical one in "internal/bytealg". Remove this function and related tests. Change-Id: I018a92902f881836699c6a90511359d8bfa16f80 GitHub-Last-Rev: d9c8917253d9e961798660ac62fa8e8ba35523bc GitHub-Pull-Request: golang/go#78029 Reviewed-on: https://go-review.googlesource.com/c/go/+/753080 Reviewed-by: Keith Randall Reviewed-by: Keith Randall Auto-Submit: Keith Randall LUCI-TryBot-Result: Go LUCI Reviewed-by: Mark Freeman --- src/bytes/bytes_test.go | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) (limited to 'src/bytes/bytes_test.go') diff --git a/src/bytes/bytes_test.go b/src/bytes/bytes_test.go index 891aef2c8b..07280464d2 100644 --- a/src/bytes/bytes_test.go +++ b/src/bytes/bytes_test.go @@ -323,10 +323,6 @@ func TestIndexByte(t *testing.T) { if pos != tt.i { t.Errorf(`IndexByte(%q, '%c') = %v`, tt.a, b, pos) } - posp := IndexBytePortable(a, b) - if posp != tt.i { - t.Errorf(`indexBytePortable(%q, '%c') = %v`, tt.a, b, posp) - } } } @@ -617,8 +613,18 @@ func BenchmarkIndexByte(b *testing.B) { benchBytes(b, indexSizes, bmIndexByte(IndexByte)) } +// indexBytePortable use as the baseline for performance comparisons. +func indexBytePortable(s []byte, c byte) int { + for i, b := range s { + if b == c { + return i + } + } + return -1 +} + func BenchmarkIndexBytePortable(b *testing.B) { - benchBytes(b, indexSizes, bmIndexByte(IndexBytePortable)) + benchBytes(b, indexSizes, bmIndexByte(indexBytePortable)) } func bmIndexByte(index func([]byte, byte) int) func(b *testing.B, n int) { -- cgit v1.3