From f35e6df70bf3cbb748657a58f9b5bb9a9a491b69 Mon Sep 17 00:00:00 2001 From: "Nicholas S. Husin" Date: Mon, 13 Apr 2026 20:58:19 -0400 Subject: net/http: temporarily disable HTTP/3 tests Tests for HTTP/3 are unfortunately still flaky. The flakes seem to come mostly from two sources: 1. QUIC connections are not shutdown fast enough, causing them to be detected as goroutine leaks. 2. x/net/quic has a race condition where its output buffer are written to without locks (synchronously and intentionally, for optimization), but may be asynchronously written when the QUIC stream receives a STOP_SENDING frame. Therefore, skip http3Mode for now until the above flakes are fixed. For #70914 Fixes #78701 Change-Id: If0c857c0933b977fb10a4481124680726a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/766740 Reviewed-by: Nicholas Husin Auto-Submit: Nicholas Husin LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com Reviewed-by: Carlos Amedee --- src/net/http/clientserver_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/net/http/clientserver_test.go b/src/net/http/clientserver_test.go index 0bcc950103..a1258089c7 100644 --- a/src/net/http/clientserver_test.go +++ b/src/net/http/clientserver_test.go @@ -112,6 +112,12 @@ func run[T TBRun[T]](t T, f func(t T, mode testMode), opts ...any) { setParallel(t) } for _, mode := range modes { + // HTTP/3 tests are unfortunately still flakier than we would like. + // Disable them for now. + // TODO(nsh): re-enable the tests once they are no longer flaky. + if mode == http3Mode { + continue + } t.Run(string(mode), func(t T) { t.Helper() if t, ok := any(t).(*testing.T); ok && parallel { -- cgit v1.3