From b7db5702b0743209c7bc9fb4e4c8683549325621 Mon Sep 17 00:00:00 2001 From: Mark Freeman Date: Fri, 10 Apr 2026 16:55:29 -0400 Subject: cmd/compile/internal/noder: revert to UIR V3 Upgrading to V4 early doesn't seem to make much sense while we refine things. Any change to encoding would require another version gate and propagation; this gets tedious fast. Instead, let's keep on V3 and test locally with V4. We can commit skipped tests as we refine and then turn them all on *with* the bump up to V4. Change-Id: I571715e5da75095612f68b224c82e6d22ad3ab25 Reviewed-on: https://go-review.googlesource.com/c/go/+/765444 LUCI-TryBot-Result: Go LUCI Reviewed-by: Alan Donovan Auto-Submit: Mark Freeman --- src/cmd/compile/internal/noder/unified.go | 4 ++-- test/genmeth.go | 2 +- test/genmeth1.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cmd/compile/internal/noder/unified.go b/src/cmd/compile/internal/noder/unified.go index 320fb3c75a..2a84a9aee4 100644 --- a/src/cmd/compile/internal/noder/unified.go +++ b/src/cmd/compile/internal/noder/unified.go @@ -25,8 +25,8 @@ import ( ) // uirVersion is the unified IR version to use for encoding/decoding. -// Use V4 for generic methods. -const uirVersion = pkgbits.V4 +// Use V4 for generic methods; keep at V3 while we refine and test. +const uirVersion = pkgbits.V3 // localPkgReader holds the package reader used for reading the local // package. It exists so the unified IR linker can refer back to it diff --git a/test/genmeth.go b/test/genmeth.go index c802c744e4..41c23a0da4 100644 --- a/test/genmeth.go +++ b/test/genmeth.go @@ -1,4 +1,4 @@ -//run +// skip // Copyright 2026 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style diff --git a/test/genmeth1.go b/test/genmeth1.go index cf782a2513..311b82d12c 100644 --- a/test/genmeth1.go +++ b/test/genmeth1.go @@ -1,4 +1,4 @@ -//run +// skip // Copyright 2026 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style -- cgit v1.3