| Age | Commit message (Collapse) | Author |
|
Fixes #2950.
Fixes #2951.
R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/5672044
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5645099
|
|
I hate symlinks.
Fixes #2787.
R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5638043
|
|
TBR=golang-dev
CC=golang-dev
https://golang.org/cl/5625050
|
|
This reduces the overhead necessary to work with OS-specific
file details, hides the implementation of FileStat, and
preserves the implementation-specific nature of Sys.
Expressions such as:
stat.(*os.FileInfo).Sys.(*syscall.Stat_t).Uid
fi1.(*os.FileStat).SameFile(fi2.(*os.FileStat))
Are now spelled as::
stat.Sys().(*syscall.Stat_t).Uid
os.SameFile(fi1, fi2)
R=cw, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5448079
|
|
Consequently, remove many package Makefiles,
and shorten the few that remain.
gomake becomes 'go tool make'.
Turn off test phases of run.bash that do not work,
flagged with $BROKEN. Future CLs will restore these,
but this seemed like a big enough CL already.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5601057
|
|
If there's an error, sometimes you need to stop.
Part of issue 2787.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5570068
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5501069
|
|
There was Base but not Dir, so fill in the gap.
R=n13m3y3r, r, rsc, gustavo
CC=golang-dev
https://golang.org/cl/5503067
|
|
Fixes #2593.
R=rsc, alex.brainman, n13m3y3r
CC=golang-dev
https://golang.org/cl/5500052
|
|
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5501052
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5476048
|
|
R=golang-dev, bradfitz, gri
CC=golang-dev
https://golang.org/cl/5451079
|
|
R=golang-dev, r, r, gri, bradfitz, iant, iant, nigeltao, n13m3y3r
CC=golang-dev
https://golang.org/cl/5416060
|
|
Fixes #2493.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5433079
|
|
R=rsc
CC=golang-dev
https://golang.org/cl/5345045
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5319072
|
|
R=golang-dev, bsiegert, iant
CC=golang-dev
https://golang.org/cl/5294074
|
|
use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
|
|
R=golang-dev, rsc, gustavo, r, borman
CC=golang-dev
https://golang.org/cl/4981049
|
|
filepath.Glob is documented to return nil if no files match
and an error only if the pattern is invalid. This change
fixes it to work as documented and adds a regression test.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5040045
|
|
The go/build package already recognizes
system-specific file names like
mycode_darwin.go
mycode_darwin_386.go
mycode_386.s
However, it is also common to write files that
apply to multiple architectures, so a recent CL added
to go/build the ability to process comments
listing a set of conditions for building. For example:
// +build darwin freebsd openbsd/386
says that this file should be compiled only on
OS X, FreeBSD, or 32-bit x86 OpenBSD systems.
These conventions are not yet documented
(hence this long CL description).
This CL adds build comments to the multi-system
files in the core library, a step toward making it
possible to use go/build to build them.
With this change go/build can handle crypto/rand,
exec, net, path/filepath, os/user, and time.
os and syscall need additional adjustments.
R=golang-dev, r, gri, r, gustavo
CC=golang-dev
https://golang.org/cl/5011046
|
|
R=golang-dev, cw
CC=golang-dev
https://golang.org/cl/5004045
|
|
This one uses a closure than an interface, and is much simpler to use.
It also enables a called function to return an error and (possibly)
halt processing.
Fixes #2237.
R=golang-dev, gri, rsc, r, cw, n13m3y3r
CC=golang-dev
https://golang.org/cl/5014043
|
|
The path is not in fact relative to the root, but
joined to it.
R=golang-dev, adg, rsc, gustavo
CC=golang-dev
https://golang.org/cl/4977059
|
|
Fixes #2201
R=golang-dev, r, rsc, alex.brainman, robert.hencke, jp
CC=golang-dev
https://golang.org/cl/4950051
|
|
API change. Needs further reflection.
««« original CL description
path/filepath: Simplify Walk interface
The last argument of filepath.Walk was removed, and the Visitor
interface now contains an Error method that is called on errors.
Fixes #2237.
R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/4964067
»»»
R=r
CC=golang-dev
https://golang.org/cl/4974065
|
|
The last argument of filepath.Walk was removed, and the Visitor
interface now contains an Error method that is called on errors.
Fixes #2237.
R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/4964067
|
|
R=r
CC=golang-dev
https://golang.org/cl/4984052
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4837048
|
|
R=golang-dev, mattn.jp, adg
CC=golang-dev
https://golang.org/cl/4746047
|
|
- Clean and IsAbs to handle paths with drive letter properly.
- Clean to replace / with \.
R=golang-dev, adg
CC=golang-dev, mattn.jp
https://golang.org/cl/4758051
|
|
R=bradfitz
CC=golang-dev
https://golang.org/cl/4704047
|
|
Includes 'sorthelpers' gofix and updates to tree.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4631098
|
|
Change the signature of Split to have no count,
assuming a full split, and rename the existing
Split with a count to SplitN.
Do the same to package bytes.
Add a gofix module.
R=adg, dsymonds, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/4661051
|
|
R=golang-dev
CC=golang-dev
https://golang.org/cl/4630066
|
|
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4517132
|
|
also make the error prints better in the test.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4556069
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4527090
|
|
When I was first coding Abs, I wondered if people wouldn't
expect the path to be consistently clean, even if the path
passed in was already absolute.
CL 4524078 has a potential problem based on exactly that
assumption, so it feels like this behavior is indeed the
most useful and least surprising.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4548074
|
|
MkdirAll() need to use isSeparator().
Move primary defines of filepath.Separator/filepath.ListSeparator
to os.PathSeparator/os.PathListSeparator.
Move filepath.isSeparator() to os.IsPathSeparator().
filepath package refer them from os package.
Fixes #1831.
R=rsc, alex.brainman
CC=golang-dev
https://golang.org/cl/4535100
|
|
Fixes #1830.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4526060
|
|
R=rsc
CC=golang-dev
https://golang.org/cl/4442064
|
|
We replace the current Open with:
OpenFile(name, flag, perm) // same as old Open
Open(name) // same as old Open(name, O_RDONLY, 0)
Create(name) // same as old Open(name, O_RDWR|O_TRUNC|O_CREAT, 0666)
This CL includes a gofix module and full code updates: all.bash passes.
(There may be a few comments I missed.)
The interesting packages are:
gofix
os
Everything else is automatically generated except for hand tweaks to:
src/pkg/io/ioutil/ioutil.go
src/pkg/io/ioutil/tempfile.go
src/pkg/crypto/tls/generate_cert.go
src/cmd/goyacc/goyacc.go
src/cmd/goyacc/units.y
R=golang-dev, bradfitzwork, rsc, r2
CC=golang-dev
https://golang.org/cl/4357052
|
|
R=golang-dev, rsc1, peterGo, bsiegert, r, mattn
CC=golang-dev
https://golang.org/cl/4271057
|
|
The error will only occur for invalid patterns, but without this
error path there is no way to know that Glob has failed due to
an invalid pattern.
R=rsc
CC=golang-dev
https://golang.org/cl/4346044
|
|
R=paulzhol, ality, r, fhs
CC=golang-dev
https://golang.org/cl/4316054
|
|
Fixes #1610.
R=rsc
CC=golang-dev
https://golang.org/cl/4355042
|
|
Fixes #1622.
R=rsc, bradfitzgo
CC=golang-dev
https://golang.org/cl/4287063
|
|
R=golang-dev, rsc1
CC=adg, golang-dev
https://golang.org/cl/4274069
|