| Age | Commit message (Collapse) | Author |
|
Fixes #4804
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/7819043
|
|
Fixes #4902
R=golang-dev, alex.brainman, r, google
CC=golang-dev
https://golang.org/cl/7579045
|
|
Return nice errors and don't panic.
Fixes #4859
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7383046
|
|
And add a test too, for Alex. :)
Fixes #3734
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7399046
|
|
Simplifies the contract for Driver.Stmt.Close in
the process of fixing issue 3865.
Fixes #3865
Update #4459 (maybe fixes it; uninvestigated)
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7363043
|
|
It used to be package "db" but was long ago renamed
to be "sql".
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7322075
|
|
Completly the same like the Execer-Interface, just for Queries.
This allows Drivers to execute Queries without preparing them first
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7085056
|
|
Update #3865
R=golang-dev, alex.brainman, nightlyone
CC=golang-dev
https://golang.org/cl/7324051
|
|
Fixes #3460
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/7096046
|
|
Fixes #3678.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6460087
|
|
caught by https://github.com/lyda/misspell-check.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/6949072
|
|
Tests that here should be automatic retries if a database
driver's connection returns ErrBadConn on Begin. See
"TestTxErrBadConn" in sql_test.go
R=golang-dev
CC=golang-dev
https://golang.org/cl/6942050
|
|
driver.Conn.Begin returns driver.ErrBadConn
Fixes #4433
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6845094
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6826044
|
|
The second parameter for sql.putConn() (err) is always nil. As a result bad
connections are reused, even if the driver returns an driver.ErrBadConn.
Unsing a pointer to err instead achievs the desired behavior.
See http://code.google.com/p/go/issues/detail?id=3777 for more details.
Fixes #3777.
R=golang-dev, dave, bradfitz, jameshuachow, BlakeSGentry
CC=golang-dev
https://golang.org/cl/6348069
|
|
Ran 'double.pl' on the pkg tree to identify doubled words.
One change to an error string return in x509; the rest are in comments.
Thanks to Matt Jibson for the idea.
R=golang-dev, bsiegert
CC=golang-dev
https://golang.org/cl/6344089
|
|
It was only being used for (*Stmt).Exec, not Query, and not for
the same two methods on *DB.
This unifies (*Stmt).Exec's old inline code into the old
subsetArgs function, renaming it in the process (changing the
old word "subset" to "driver", mostly converted earlier)
Fixes #3640
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6258045
|
|
Fixes #3449
R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/5970076
|
|
To make sure that there is no resource leak,
I suggest to fix the 'fakedb' driver such as it fails when any
Stmt is not closed.
First, add a check in fakeConn.Close().
Then, fix all missing Stmt.Close()/Rows.Close().
I am not sure that the strategy choose in fakeConn.Prepare/prepare* is ok.
The weak point in this patch is the change in Tx.Query:
- Tests pass without this change,
- I found it by manually analyzing the code,
- I just try to make Tx.Query look like DB.Query.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5759050
|
|
In a transaction, on a Stmt.Query error, it was possible for a
connection to be added to a db's freelist twice. Should use
the local releaseConn function instead.
Thanks to Gwenael Treguier for the failing test.
Also in this CL: propagate driver errors through releaseConn
into *DB.putConn, which conditionally ignores the freelist
addition if the driver signaled ErrBadConn, introduced in a
previous CL.
R=golang-dev, gary.burd
CC=golang-dev
https://golang.org/cl/5798049
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5781058
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5785043
|
|
Fixes #3223
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5755063
|
|
Bug reported by Blake Mizerany found while writing
his new Postgres driver.
R=golang-dev, blake.mizerany
CC=golang-dev
https://golang.org/cl/5754057
|
|
-- add driver.Value type and documentation,
convert from interface{} to Value where
appropriate.
-- don't say "subset" anywhere,
-- SubsetValuer -> Valuer
-- SubsetValue -> Value
-- IsParameterSubsetType -> IsValue
-- IsScanSubsetType -> IsScanValue
Fixes #2842
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5674084
|
|
Also fix a doc error.
Fixes #2843
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5653050
|
|
If the database driver supports the Execer interface but returns
ErrSkip, calling Exec on a transaction was returning the error instead
of using the slow path.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5654044
|
|
Part of issue 2843
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5646063
|
|
Higher level tests for the pointer parameters
and scanning, complementing the existing ones
included in the previous CL.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5646050
|
|
- convert from nil pointers to the nil interface{}
- dereference non-nil pointers
- convert from nil interface{}s to nil pointers
- allocate pointers for non-nil interface{}s
- tests for all of the above
R=golang-dev, bradfitz, rsc, rogpeppe
CC=golang-dev
https://golang.org/cl/5630052
|
|
Specifically, remove simply where it is claiming that the
code or the action to be carried out is simple, since the
reader might disagree.
R=golang-dev, bradfitz, gri
CC=golang-dev
https://golang.org/cl/5637048
|
|
See thread http://goo.gl/7zzzU for background.
R=rsc
CC=golang-dev
https://golang.org/cl/5624051
|
|
R=rsc, dsymonds, bsiegert, rogpeppe
CC=golang-dev
https://golang.org/cl/5619052
|
|
Consequently, remove many package Makefiles,
and shorten the few that remain.
gomake becomes 'go tool make'.
Turn off test phases of run.bash that do not work,
flagged with $BROKEN. Future CLs will restore these,
but this seemed like a big enough CL already.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5601057
|
|
Also allow string values to scan into []byte.
Fixes #2788.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5577054
|
|
Fixes #2784
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5574073
|
|
Fixes #2699
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5557063
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5536076
|