aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-05-20spec: specify order of init() callsgo1.3beta2Robert Griesemer
The spec did not specify the order in which init() functions are called. Specify that they are called in source order since we have now also specified the initialization order of independent variables. While technically a language change, no existing code could have relied on this, so this should not break anything. Per suggestion from rsc. LGTM=r, iant R=rsc, iant, r, ken CC=golang-codereviews https://golang.org/cl/98420046
2014-05-20reflect: don't panic on delete from nil map.Keith Randall
Fixes #8051 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/95560046
2014-05-20spec: clarify section on package initializationRobert Griesemer
- split description of package initialization and program execution - better grouping of concerns in section on package initialization - more explicit definition of what constitues a dependency - removed language about constant dependencies - they are computed at compile-time and not initialized at run-time - clarified that independent variables are initialized in declaration order (rather than reference order) Note that the last clarification is what distinguishes gc and gccgo at the moment: gc uses reference order (i.e., order in which variables are referenced in initialization expressions), while gccgo uses declaration order for independent variables. Not a language change. But adopting this CL will clarify what constitutes a dependency. Fixes #6703. LGTM=adonovan, r, iant, rsc R=r, rsc, iant, ken, adonovan CC=golang-codereviews https://golang.org/cl/99020043
2014-05-20doc/go_spec.html: fix broken anchor tagRob Pike
LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/99420045
2014-05-20doc/install.html: fix duplicate id= tagRob Pike
LGTM=minux.ma R=adg, minux.ma CC=golang-codereviews https://golang.org/cl/95540045
2014-05-20all: fix "the the" typos.Shenghou Ma
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/93470043
2014-05-20runtime: revise the document of Version()Shenghou Ma
Fixes #7701. (again, differently) LGTM=rsc R=iant, rsc CC=golang-codereviews https://golang.org/cl/94560043
2014-05-20src: make nacltest.bash executableBrad Fitzpatrick
TBR=rsc R=rsc CC=golang-codereviews https://golang.org/cl/98480043
2014-05-20undo CL 84040045 / 5302b4c58aa0Shenghou Ma
This idea was rejected in CL 5731059. We should fix the runtime docs instead. ««« original CL description cmd/dist: reflect local changes to tree in goversion runtime.Version() requires a trailing "+" when tree had local modifications at time of build. Fixes #7701 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84040045 »»» LGTM=rsc, mra R=iant, rsc, mra CC=golang-codereviews https://golang.org/cl/100520043
2014-05-20debug/plan9obj: cleanup apiDavid du Colombier
- Don't export Prog structure. - Remove ProgHeader and ExecTable structures. - Add Magic, Bss and Entry fields in FileHeader. - Replace ?_MAGIC variables with constants. - Ignore final EOF from ReadAt. - Improve documentation. Fixes #7989. LGTM=rsc R=rsc, bradfitz CC=golang-codereviews https://golang.org/cl/91400044
2014-05-20cmd/go: document file typesRob Pike
Explain which files the go command looks at, and what they represent. Fixes #6348. LGTM=rsc R=rsc, minux.ma CC=golang-codereviews https://golang.org/cl/96480043
2014-05-20doc/go1.3.html: mention cgo [0]byte bug fix falloutRuss Cox
Fixes #7958. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/91590044
2014-05-20build: make nacl passRuss Cox
Add nacl.bash, the NaCl version of all.bash. It's a separate script because it builds a variant of package syscall with a large zip file embedded in it, containing all the input files needed for tests. Disable various tests new since the last round, mostly the ones using os/exec. Fixes #7945. LGTM=dave R=golang-codereviews, remyoudompheng, dave, bradfitz CC=golang-codereviews https://golang.org/cl/100590044
2014-05-20test: test issue 7884 (already fixed)Russ Cox
I don't know when the bug was fixed, but empirically it was. Make sure it stays fixed by adding a test. Fixes #7884. LGTM=adg R=golang-codereviews, adg CC=golang-codereviews https://golang.org/cl/93500043
2014-05-20syscall: fix Write(nil) on NaClRuss Cox
Fixes #7050. LGTM=crawshaw, r R=golang-codereviews, crawshaw, r CC=golang-codereviews https://golang.org/cl/91590043
2014-05-20cmd/ld: make lldb happy with Mach-O 6.out filesRuss Cox
Apparently all the __DWARF sections need addresses even though they are marked as "do not load from disk". Continue the address numbering from the data segment. With this change: g% lldb helloworld Current executable set to 'helloworld' (x86_64). (lldb) b main.main Breakpoint 1: where = helloworld`main.main + 25 at helloworld.go:12, address = 0x0000000000002019 (lldb) r Process 68509 launched: '/Users/rsc/g/go/src/cmd/6l/helloworld' (x86_64) 1 location added to breakpoint 1 (lldb) Process 68509 stopped * thread #1: tid = 0x8b7a27, 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12, stop reason = breakpoint 1.2 frame #0: 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12 9 package main 10 11 func main() { -> 12 print("hello, world\n") 13 } (lldb) bt * thread #1: tid = 0x8b7a27, 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12, stop reason = breakpoint 1.2 * frame #0: 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12 (lldb) disas helloworld`main.main at helloworld.go:11: 0x2000: movq %gs:0x8a0, %rcx 0x2009: cmpq (%rcx), %rsp 0x200c: ja 0x2015 ; main.main + 21 at helloworld.go:11 0x200e: callq 0x20da0 ; runtime.morestack00_noctxt at atomic_amd64x.c:28 0x2013: jmp 0x2000 ; main.main at helloworld.go:11 0x2015: subq $0x10, %rsp -> 0x2019: leaq 0x2c2e0, %rbx 0x2021: leaq (%rsp), %rbp 0x2025: movq %rbp, %rdi 0x2028: movq %rbx, %rsi 0x202b: movsq 0x202d: movsq 0x202f: callq 0x10300 ; runtime.printstring at compiler.go:1 0x2034: addq $0x10, %rsp 0x2038: ret 0x2039: addb %al, (%rax) 0x203b: addb %al, (%rax) 0x203d: addb %al, (%rax) (lldb) quit Quitting LLDB will kill one or more processes. Do you really want to proceed: [Y/n] y g% Fixes #7070. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/93510043
2014-05-20misc/makerelease: handle update tour file layoutAndrew Gerrand
Fixes #7835. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/94670044
2014-05-20doc/go1.3.html: switch default stack size back to 8kBMikio Hara
Update #8030 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/94680043
2014-05-20cmd/cgo: document CC_FOR_TARGET and CXX_FOR_TARGETElias Naur
Update #4714 LGTM=iant, minux.ma, rsc R=rsc, iant, r, minux.ma CC=golang-codereviews https://golang.org/cl/100390043
2014-05-20liblink: fix field trackingRuss Cox
The USEFIELD instructions no longer make it to the linker, so we have to do something else to pin the references they were pinning. Emit a 0-length relocation of type R_USEFIELD. Fixes #7486. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews, r https://golang.org/cl/95530043
2014-05-20runtime: switch default stack size back to 8kBRuss Cox
The move from 4kB to 8kB in Go 1.2 was to eliminate many stack split hot spots. The move back to 4kB was predicated on copying stacks eliminating the potential for hot spots. Unfortunately, the fact that stacks do not copy 100% of the time means that hot spots can still happen under the right conditions, and the slowdown is worse now than it was in Go 1.2. There is a real program in issue 8030 that sees about a 30x slowdown: it has a reflect call near the top of the stack which inhibits any stack copying on that segment. Go back to 8kB until stack copying can be used 100% of the time. Fixes #8030. LGTM=khr, dave, iant R=iant, khr, r, bradfitz, dave CC=golang-codereviews https://golang.org/cl/92540043
2014-05-19cmd/gc: fix float32 const conversion and printing of big float constsRuss Cox
The float32 const conversion used to round to float64 and then use the hardware to round to float32. Even though there was a range check before this conversion, the double rounding introduced inaccuracy: the round to float64 might round the value further away from the float32 range, reaching a float64 value that could not actually be rounded to float32. The hardware appears to give us 0 in that case, but it is probably undefined. Double rounding also meant that the wrong value might be used for certain border cases. Do the rounding the float32 ourselves, just as we already did the rounding to float64. This makes the conversion precise and also makes the conversion match the range check. Finally, add some code to print very large (bigger than float64) floating point constants in decimal floating point notation instead of falling back to the precise but human-unreadable binary floating point notation. Fixes #8015. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews, r https://golang.org/cl/100580044
2014-05-19cmd/ld: abort if (32-bit) address relocation is negative on amd64.Shenghou Ma
Update #7980 This CL make the linker abort for the example program. For Go 1.4, we need to find a general way to handle large memory model programs. LGTM=dave, josharian, iant R=iant, dave, josharian CC=golang-codereviews https://golang.org/cl/91500046
2014-05-19text/template,html/template: document that partial results may be written on ↵Rob Pike
error Fixes #7445. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/94640043
2014-05-19cmd/gc: fix <-<-exprRuss Cox
The temporary-introducing pass was not recursing into the argumnt of a receive operation. Fixes #8011. LGTM=r R=golang-codereviews, r CC=golang-codereviews, iant, khr https://golang.org/cl/91540043
2014-05-19net/http: document that ProxyFromEnvironment special-cases localhostBrad Fitzpatrick
Fixes #7256 LGTM=r R=golang-codereviews, r CC=golang-codereviews, rsc https://golang.org/cl/97590043
2014-05-19database/sql: more docs explaining that DB is a poolBrad Fitzpatrick
This is the main point of confusion and the emphasis of a recent Gophercon talk. Fixes #5886. (mostly fixed in previous commits) LGTM=r R=r CC=golang-codereviews https://golang.org/cl/100560043
2014-05-19math/rand: restore Go 1.2 value stream for Float32, Float64Russ Cox
CL 22730043 fixed a bug in these functions: they could return 1.0 despite documentation saying otherwise. But the fix changed the values returned in the non-buggy case too, which might invalidate programs depending on a particular stream when using rand.Seed(0) or when passing their own Source to rand.New. The example test says: // These tests serve as an example but also make sure we don't change // the output of the random number generator when given a fixed seed. so I think there is some justification for thinking we have promised not to change the values. In any case, there's no point in changing the values gratuitously: we can easily fix this bug without changing the values, and so we should. That CL just changed the test values too, which defeats the stated purpose, but it was just a comment. Add an explicit regression test, which might be a clearer signal next time that we don't want to change the values. Fixes #6721. (again) Fixes #8013. LGTM=r R=iant, r CC=golang-codereviews https://golang.org/cl/95460049
2014-05-19spec: clarify when a program exitsRobert Griesemer
Fixes #8023. LGTM=rsc R=r, iant, ken, rsc CC=golang-codereviews https://golang.org/cl/98340043
2014-05-19doc/go1.3.html: minor tweak of Solaris wordingAram Hăvărneanu
Discussion here: https://golang.org/cl/100490044/#msg14 LGTM=r R=r CC=golang-codereviews https://golang.org/cl/98350043
2014-05-19reflect: test, fix access to nil mapsRuss Cox
Fixes #8010. LGTM=bradfitz, khr R=khr, bradfitz, dvyukov CC=golang-codereviews https://golang.org/cl/91450048
2014-05-19runtime: fix freeOSMemory to free memory immediatelyDmitriy Vyukov
Currently freeOSMemory makes only marking phase of GC, but not sweeping phase. So recently memory is not released after freeOSMemory. Do both marking and sweeping during freeOSMemory. Fixes #8019. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, rsc https://golang.org/cl/97550043
2014-05-19C: add Burcu Dogan (Google CLA)Andrew Gerrand
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/94610043
2014-05-18doc/go1.3.html: fix typoMikio Hara
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/92440043
2014-05-17syscall: fix arm buildDave Cheney
Rename Seek to seek in asm file, was overlooked in CL 99320043. LGTM=bradfitz, r R=r, rsc, bradfitz CC=golang-codereviews https://golang.org/cl/99320044
2014-05-16net/http: allow Content-Type on 204 responsesBrad Fitzpatrick
Accidental change from fixing Content-Length on 204s in http://golang.org/issue/6685 earlier. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/92400047
2014-05-16lib/time/zoneinfo.zip: update to IANA release 2014cRob Pike
LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews https://golang.org/cl/93420046
2014-05-17doc/go1.3.html: update the state of supported platformsMikio Hara
LGTM=r R=golang-codereviews, aram, 0intro, gobot, r CC=golang-codereviews https://golang.org/cl/100490044
2014-05-16encoding/xml: fix format in test messageRob Pike
Found by go vet. LGTM=crawshaw R=golang-codereviews, crawshaw CC=golang-codereviews https://golang.org/cl/100510044
2014-05-16spec: clarify that newlines are kept in raw string literalsIan Lance Taylor
Fixes #8007. LGTM=r R=gri, r CC=golang-codereviews https://golang.org/cl/91510044
2014-05-16syscall: fix linux amd64 buildRob Pike
TBR=rsc TBR=rsc R=rsc CC=golang-codereviews https://golang.org/cl/100500047
2014-05-16syscall: fix a few Linux system callsRuss Cox
These functions claimed to return error (an interface) and be implemented entirely in assembly, but it's not possible to create an interface from assembly (at least not easily). In reality the functions were written to return an errno uintptr despite the Go prototype saying error. When the errno was 0, they coincidentally filled out a nil error by writing the 0 to the type word of the interface. If the errno was ever non-zero, the functions would create a non-nil error that would crash when trying to call err.Error(). Luckily these functions (Seek, Time, Gettimeofday) pretty much never fail, so it was all kind of working. Found by go vet. LGTM=bradfitz, r R=golang-codereviews, bradfitz, r CC=golang-codereviews https://golang.org/cl/99320043
2014-05-16doc/go1.3.html: add note about small map iteration orderRuss Cox
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/98290048
2014-05-16cmd/addr2line, cmd/objdump: handle Plan 9 a.out object filesDavid du Colombier
Update #7947. LGTM=iant R=rsc, iant CC=golang-codereviews https://golang.org/cl/91500044
2014-05-16doc/go1.3.html: add syscall.SendmsgNMikio Hara
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/93430044
2014-05-15cmd/pack: buffer writes in TestLargeDefsAnthony Martin
TestLargeDefs was issuing over one million small writes to create a 7MB file (large.go). This is quite slow on Plan 9 since our disk file systems aren't very fast and they're usually accessed over the network. Buffering the writes makes the test about six times faster. Even on Linux, it's about 1.5 times faster. Here are the results on a slow Plan 9 machine: Before: % ./pack.test -test.v -test.run TestLargeDefs === RUN TestLargeDefs --- PASS: TestLargeDefs (125.11 seconds) PASS After: % ./pack.test -test.v -test.run TestLargeDefs === RUN TestLargeDefs --- PASS: TestLargeDefs (20.835 seconds) PASS LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/95040044
2014-05-15api: update next.txtShenghou Ma
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/95490043
2014-05-15cmd/gc: fix two select temporary bugsRuss Cox
The introduction of temporaries in order.c was not quite right for two corner cases: 1) The rewrite that pushed new variables on the lhs of a receive into the body of the case was dropping the declaration of the variables. If the variables escape, the declaration is what allocates them. Caught by escape analysis sanity check. In fact the declarations should move into the body always, so that we only allocate if the corresponding case is selected. Do that. (This is an optimization that was already present in Go 1.2. The new order code just made it stop working.) Fixes #7997. 2) The optimization to turn a single-recv select into an ordinary receive assumed it could take the address of the destination; not so if the destination is _. Fixes #7998. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/100480043
2014-05-15archive/tar: Do not panic on Read if uninitializedGuillaume J. Charmes
Calling tar.Reader.Read() used to work fine, but without this patch it panics. Simply return EOF to indicate the tar.Reader.Next() needs to be called. LGTM=iant, bradfitz R=golang-codereviews, bradfitz, iant, mikioh.mikioh, dominik.honnef CC=golang-codereviews https://golang.org/cl/94530043
2014-05-16api: update openbsd exceptionsMikio Hara
This CL restores dropped constants not supported in OpenBSD 5.5 and tris to keep the promise of API compatibility. Update #7049 LGTM=jsing, bradfitz R=rsc, jsing, bradfitz CC=golang-codereviews https://golang.org/cl/94950043
generated by cgit v1.3 (git 2.53.0) at 2026-04-15 03:08:35 +0000