diff options
| author | Damien Neil <dneil@google.com> | 2022-11-14 10:21:51 -0800 |
|---|---|---|
| committer | Damien Neil <dneil@google.com> | 2022-11-14 19:44:44 +0000 |
| commit | 24fc64028c0faa7fcbdae2bf2a2ded825713c982 (patch) | |
| tree | ec0ae1582310fca03a5b05e4e6132acbcaa8638c /src | |
| parent | 6234e467e50b35e967b9a91f8b6fa01fa6691bfa (diff) | |
| download | go-24fc64028c0faa7fcbdae2bf2a2ded825713c982.tar.xz | |
os: don't request read access from CreateFile in Stat
CL 448897 changed os.Stat to request GENERIC_READ access when using
CreateFile to examine a file. This is unnecessary; access flags of 0
will permit examining file metadata even if the file isn't readable.
Revert to the old behavior here.
For #56217
Change-Id: I09220b3bbee304bd89f4a94ec9b0af42042b7773
Reviewed-on: https://go-review.googlesource.com/c/go/+/450296
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/os/stat_windows.go | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/os/stat_windows.go b/src/os/stat_windows.go index 4116e77170..f8f229c709 100644 --- a/src/os/stat_windows.go +++ b/src/os/stat_windows.go @@ -69,12 +69,8 @@ func stat(funcname, name string, createFileAttrs uint32) (FileInfo, error) { } // Finally use CreateFile. - h, err := syscall.CreateFile(namep, - syscall.GENERIC_READ, - syscall.FILE_SHARE_READ|syscall.FILE_SHARE_WRITE, - nil, - syscall.OPEN_EXISTING, - createFileAttrs, 0) + h, err := syscall.CreateFile(namep, 0, 0, nil, + syscall.OPEN_EXISTING, createFileAttrs, 0) if err != nil { return nil, &PathError{Op: "CreateFile", Path: name, Err: err} } |