diff options
| author | Baokun Lee <nototon@gmail.com> | 2019-11-07 20:23:06 +0800 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2019-11-08 19:28:49 +0000 |
| commit | f6ff806e48ca48f080d1534e2c8ef4db84abdb7e (patch) | |
| tree | ea7eca34f0d95a13a4dea55f875c3530afc3b18e /src | |
| parent | e6c12c3d0296251f1d5a96ebde811dbfd4a914fe (diff) | |
| download | go-f6ff806e48ca48f080d1534e2c8ef4db84abdb7e.tar.xz | |
cmd/go: refuse -w with an invalid GOPATH
Fixes #35338
Change-Id: Ic2a3a446ef56b1e5723d6192c8aeec32ae0bbeac
Reviewed-on: https://go-review.googlesource.com/c/go/+/205779
Run-TryBot: Baokun Lee <nototon@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/go/internal/envcmd/env.go | 7 | ||||
| -rw-r--r-- | src/cmd/go/testdata/script/env_write.txt | 7 |
2 files changed, 14 insertions, 0 deletions
diff --git a/src/cmd/go/internal/envcmd/env.go b/src/cmd/go/internal/envcmd/env.go index da704777f5..023d542d88 100644 --- a/src/cmd/go/internal/envcmd/env.go +++ b/src/cmd/go/internal/envcmd/env.go @@ -353,6 +353,13 @@ func checkEnvWrite(key, val string) error { default: return fmt.Errorf("invalid %s value %q", key, val) } + case "GOPATH": + if strings.HasPrefix(val, "~") { + return fmt.Errorf("GOPATH entry cannot start with shell metacharacter '~': %q", val) + } + if !filepath.IsAbs(val) && val != "" { + return fmt.Errorf("GOPATH entry is relative; must be absolute path: %q", val) + } } if !utf8.ValidString(val) { diff --git a/src/cmd/go/testdata/script/env_write.txt b/src/cmd/go/testdata/script/env_write.txt index 7dbb1d9028..8b9c1bbf45 100644 --- a/src/cmd/go/testdata/script/env_write.txt +++ b/src/cmd/go/testdata/script/env_write.txt @@ -89,3 +89,10 @@ stderr 'arguments must be KEY=VALUE: invalid argument: GOOS' # go env -w rejects invalid GO111MODULE values, as otherwise cmd/go would break ! go env -w GO111MODULE=badvalue stderr 'invalid GO111MODULE value "badvalue"' + +# go env -w rejects invalid GOPATH values +! go env -w GOPATH=~/go +stderr 'GOPATH entry cannot start with shell metacharacter' + +! go env -w GOPATH=./go +stderr 'GOPATH entry is relative; must be absolute path' |