diff options
| author | Michael Pratt <mpratt@google.com> | 2023-06-01 12:34:20 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-06-01 19:44:26 +0000 |
| commit | d0459766c8d6b503fda7a8d9983b4aaf92a63e01 (patch) | |
| tree | e8a30ec44ad85b59a4f1dc48934bb1f6890bfa6b /src | |
| parent | fdb3dc471d099cf04cfa575a2bc8d51999917e1e (diff) | |
| download | go-d0459766c8d6b503fda7a8d9983b4aaf92a63e01.tar.xz | |
runtime: update skips for TestGdbBacktrace
One issue simply has a reworded message, probably from a new version of
GDB. Another is a new issue.
Fixes #60553.
Fixes #58698.
Updates #39204.
Change-Id: I8389aa981fab5421f57ee761bfb5e1dd237709ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/499975
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/runtime/runtime-gdb_test.go | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index 1577d0995d..19069f4462 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -470,15 +470,17 @@ func TestGdbBacktrace(t *testing.T) { got, err := cmd.CombinedOutput() t.Logf("gdb output:\n%s", got) if err != nil { - if bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")) { + switch { + case bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")): // GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28551 testenv.SkipFlaky(t, 43068) - } - if bytes.Contains(got, []byte("Couldn't get registers: No such process.")) { + case bytes.Contains(got, []byte("Couldn't get registers: No such process.")), bytes.Contains(got, []byte("Unable to fetch general registers.: No such process.")): // GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=9086 testenv.SkipFlaky(t, 50838) - } - if bytes.Contains(got, []byte(" exited normally]\n")) { + case bytes.Contains(got, []byte("waiting for new child: No child processes.")): + // GDB bug: Sometimes it fails to wait for a clone child. + testenv.SkipFlaky(t, 60553) + case bytes.Contains(got, []byte(" exited normally]\n")): // GDB bug: Sometimes the inferior exits fine, // but then GDB hangs. testenv.SkipFlaky(t, 37405) |