diff options
| author | Ian Lance Taylor <iant@golang.org> | 2023-10-11 14:09:20 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-10-12 14:16:07 +0000 |
| commit | a762ea17ecb593d695601f0c1b4ea9fbd601c6cb (patch) | |
| tree | e94853af0602f860b2a69c28ac5f24a9b875eb6e /src | |
| parent | eb832afb2310b71db420943d91625552748ae5e6 (diff) | |
| download | go-a762ea17ecb593d695601f0c1b4ea9fbd601c6cb.tar.xz | |
runtime: don't use atomic store in noteclear on AIX
In CL 163624 we added an atomic store in noteclear on AIX only.
In the discussion on issue #63384 we think we figured out that the
real problem was in the implementation of compare-and-swap on ppc64.
That is fixed by CL 533118, so the atomic store is no longer required.
For #30189
For #63384
Change-Id: I60f4f2fac75106f2bee51a8d9663259dcde2029c
Reviewed-on: https://go-review.googlesource.com/c/go/+/534517
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Joel Sing <joel@sing.id.au>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/runtime/lock_sema.go | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/runtime/lock_sema.go b/src/runtime/lock_sema.go index e15bbf79ae..9afba08b0b 100644 --- a/src/runtime/lock_sema.go +++ b/src/runtime/lock_sema.go @@ -130,13 +130,7 @@ func unlock2(l *mutex) { // One-time notifications. func noteclear(n *note) { - if GOOS == "aix" { - // On AIX, semaphores might not synchronize the memory in some - // rare cases. See issue #30189. - atomic.Storeuintptr(&n.key, 0) - } else { - n.key = 0 - } + n.key = 0 } func notewakeup(n *note) { |