diff options
| author | Damien Neil <dneil@google.com> | 2025-06-20 14:44:09 +0100 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-06-20 12:29:58 -0700 |
| commit | 49cdf0c42e320dfed044baa551610f081eafb781 (patch) | |
| tree | 2517ae78483219b5937130a2d12b3237ce423636 /src/testing/synctest | |
| parent | 3bf1eecbd30f48851c35f608aa265c978b2cf301 (diff) | |
| download | go-49cdf0c42e320dfed044baa551610f081eafb781.tar.xz | |
testing, testing/synctest: handle T.Helper in synctest bubbles
Fixes #74199
Change-Id: I6a15fbd59a3a3f8c496440f56d09d695e1504e4e
Reviewed-on: https://go-review.googlesource.com/c/go/+/682576
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Auto-Submit: Damien Neil <dneil@google.com>
Diffstat (limited to 'src/testing/synctest')
| -rw-r--r-- | src/testing/synctest/helper_test.go | 15 | ||||
| -rw-r--r-- | src/testing/synctest/synctest_test.go | 12 |
2 files changed, 27 insertions, 0 deletions
diff --git a/src/testing/synctest/helper_test.go b/src/testing/synctest/helper_test.go new file mode 100644 index 0000000000..7547d3eac6 --- /dev/null +++ b/src/testing/synctest/helper_test.go @@ -0,0 +1,15 @@ +// Copyright 2025 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package synctest_test + +import "testing" + +// helperLog is a t.Helper which logs. +// Since it is a helper, the log prefix should contain +// the caller's file, not helper_test.go. +func helperLog(t *testing.T, s string) { + t.Helper() + t.Log(s) +} diff --git a/src/testing/synctest/synctest_test.go b/src/testing/synctest/synctest_test.go index 822fd6fe1c..9c73178750 100644 --- a/src/testing/synctest/synctest_test.go +++ b/src/testing/synctest/synctest_test.go @@ -140,6 +140,18 @@ func TestRun(t *testing.T) { }) } +func TestHelper(t *testing.T) { + runTest(t, []string{"-test.v"}, func() { + synctest.Test(t, func(t *testing.T) { + helperLog(t, "log in helper") + }) + }, `^=== RUN TestHelper + synctest_test.go:.* log in helper +--- PASS: TestHelper.* +PASS +$`) +} + func wantPanic(t *testing.T, want string) { if e := recover(); e != nil { if got := fmt.Sprint(e); got != want { |
