diff options
| author | Bryan C. Mills <bcmills@google.com> | 2023-08-24 10:45:11 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-08-24 17:32:08 +0000 |
| commit | db24f63b108eb26546aa0b675d3cb649a6b597bb (patch) | |
| tree | 04a732db25f50130e93893b2bf38d6bf3afc825a /src/syscall/exec_linux_test.go | |
| parent | fe2c686b63804b0e22295f02e4e58ddbb3da5898 (diff) | |
| download | go-db24f63b108eb26546aa0b675d3cb649a6b597bb.tar.xz | |
syscall: skip TestUnshareMountNameSpaceChroot on platforms that require external linking
TestUnshareMountNameSpaceChroot attempts to build a statically-linked
binary to run in a chroot, and sets CGO_ENABLED=0 in order to do so.
Rather than trying to figure out some other way to coax the linker
into building a static binary, let's just skip the test on Linux
platforms that require external linking (namely android/arm).
This should fix the build failure reported in
https://build.golang.org/log/1ea245a9c2e916c81043db177be76778bab00058.
While we're here, let's also fix the failure logging to make the text
readable!
Updates #46330.
Change-Id: I4fa07640ce012ac141bf4698bc3215a7f146062c
Reviewed-on: https://go-review.googlesource.com/c/go/+/522182
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/syscall/exec_linux_test.go')
| -rw-r--r-- | src/syscall/exec_linux_test.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/syscall/exec_linux_test.go b/src/syscall/exec_linux_test.go index f894bbaae9..873ae4f915 100644 --- a/src/syscall/exec_linux_test.go +++ b/src/syscall/exec_linux_test.go @@ -10,6 +10,7 @@ import ( "bytes" "flag" "fmt" + "internal/platform" "internal/testenv" "io" "os" @@ -285,6 +286,9 @@ func TestUnshareMountNameSpaceChroot(t *testing.T) { // Since we are doing a chroot, we need the binary there, // and it must be statically linked. testenv.MustHaveGoBuild(t) + if platform.MustLinkExternal(runtime.GOOS, runtime.GOARCH, false) { + t.Skipf("skipping: can't build static binary because %s/%s requires external linking", runtime.GOOS, runtime.GOARCH) + } x := filepath.Join(d, "syscall.test") t.Cleanup(func() { // If the subprocess fails to unshare the parent directory, force-unmount it @@ -297,7 +301,7 @@ func TestUnshareMountNameSpaceChroot(t *testing.T) { cmd := testenv.Command(t, testenv.GoToolPath(t), "test", "-c", "-o", x, "syscall") cmd.Env = append(cmd.Environ(), "CGO_ENABLED=0") if o, err := cmd.CombinedOutput(); err != nil { - t.Fatalf("Build of syscall in chroot failed, output %v, err %v", o, err) + t.Fatalf("%v: %v\n%s", cmd, err, o) } cmd = testenv.Command(t, "/syscall.test", "-test.run=TestUnshareMountNameSpaceChroot", "/") |