diff options
| author | qmuntal <quimmuntal@gmail.com> | 2023-01-23 12:59:29 +0100 |
|---|---|---|
| committer | Quim Muntal <quimmuntal@gmail.com> | 2023-01-24 12:56:06 +0000 |
| commit | 7b5a34418cd32ec4d2c0f7d6e4c7e6fe7585a17f (patch) | |
| tree | a14b2e6edcbbdd789633f924f4d0af222c183e23 /src/runtime/sys_windows_amd64.s | |
| parent | cf9263dee1bb160f013a080bbda3532a7d35da15 (diff) | |
| download | go-7b5a34418cd32ec4d2c0f7d6e4c7e6fe7585a17f.tar.xz | |
runtime: remove unused badsignal2 on windows
This CL removes badsignal2 function, as it is unused on Windows.
badsignal2 was originally intended to abort the process when
an exception was raised on a non-Go thread, following the same approach
as Linux and others.
Since it was added, back on https://golang.org/cl/5797068, it has caused
several issues on Windows, see #8224 and #50877. That's because we can't
know wether the signal is bad or not, as our trap might not be at the
end of the exception handler chain.
To fix those issues, https://golang.org/cl/104200046 and CL 442896
stopped calling badsignal2, and CL 458135 removed one last incorrect
call on amd64 and 386.
Change-Id: I5bd31ee2672118ae0f1a2c8b46a1bb0f4893a011
Reviewed-on: https://go-review.googlesource.com/c/go/+/463116
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/runtime/sys_windows_amd64.s')
| -rw-r--r-- | src/runtime/sys_windows_amd64.s | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/src/runtime/sys_windows_amd64.s b/src/runtime/sys_windows_amd64.s index 04e649539c..7cab08efa6 100644 --- a/src/runtime/sys_windows_amd64.s +++ b/src/runtime/sys_windows_amd64.s @@ -75,30 +75,6 @@ loadregs: RET -TEXT runtime·badsignal2(SB),NOSPLIT|NOFRAME,$48 - // stderr - MOVQ $-12, CX // stderr - MOVQ CX, 0(SP) - MOVQ runtime·_GetStdHandle(SB), AX - CALL AX - - MOVQ AX, CX // handle - MOVQ CX, 0(SP) - MOVQ $runtime·badsignalmsg(SB), DX // pointer - MOVQ DX, 8(SP) - MOVL $runtime·badsignallen(SB), R8 // count - MOVQ R8, 16(SP) - LEAQ 40(SP), R9 // written count - MOVQ $0, 0(R9) - MOVQ R9, 24(SP) - MOVQ $0, 32(SP) // overlapped - MOVQ runtime·_WriteFile(SB), AX - CALL AX - - // Does not return. - CALL runtime·abort(SB) - RET - // faster get/set last error TEXT runtime·getlasterror(SB),NOSPLIT,$0 MOVQ 0x30(GS), AX |