aboutsummaryrefslogtreecommitdiff
path: root/src/runtime/crash_cgo_test.go
diff options
context:
space:
mode:
authorBryan C. Mills <bcmills@google.com>2023-03-01 13:45:18 +0000
committerGopher Robot <gobot@golang.org>2023-03-10 20:38:29 +0000
commitd12fe60004ae5e4024c8a93f4f7de7183bb61576 (patch)
tree1f3e0ac455b4f30cb9699dcec94f939b2708f6c0 /src/runtime/crash_cgo_test.go
parent2cbab4e98c6091f5fb6cb73bdebfe328793da388 (diff)
downloadgo-d12fe60004ae5e4024c8a93f4f7de7183bb61576.tar.xz
all: skip tests that fail on android/arm64
Many of the tests skipped platforms that build PIE binaries by default, but (still) lack a central function to report which platforms those are. Some of the tests assumed (but did not check for) internal linking support, or invoked `go tool link` directly without properly configuring the external linker. A few of the tests seem to be triggering latent bugs in the linker. For #58806. For #58807. For #58794. Change-Id: Ie4d06b1597f404590ad2abf978d4c363647407ac Reviewed-on: https://go-review.googlesource.com/c/go/+/472455 Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/runtime/crash_cgo_test.go')
-rw-r--r--src/runtime/crash_cgo_test.go3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go
index 51d7bb5091..65556edd2a 100644
--- a/src/runtime/crash_cgo_test.go
+++ b/src/runtime/crash_cgo_test.go
@@ -520,6 +520,9 @@ func TestCgoTracebackSigpanic(t *testing.T) {
t.Log(got)
want := "runtime.sigpanic"
if !strings.Contains(got, want) {
+ if runtime.GOOS == "android" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64") {
+ testenv.SkipFlaky(t, 58794)
+ }
t.Errorf("did not see %q in output", want)
}
// No runtime errors like "runtime: unexpected return pc".