diff options
| author | Russ Cox <rsc@golang.org> | 2014-02-27 22:43:10 -0500 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2014-02-27 22:43:10 -0500 |
| commit | d905670c2ee3efe6b08d6c8de292be46f1e1eca1 (patch) | |
| tree | 8d3776becdb2b3c882bd584495e0374022d4fb19 /src/pkg/database/sql/sql_test.go | |
| parent | 402d3590b54e4a0df9fb51ed14b2999e85ce0b76 (diff) | |
| download | go-d905670c2ee3efe6b08d6c8de292be46f1e1eca1.tar.xz | |
[release-branch.go1.2] database/sql: Use all connections in pool
««« CL 40410043 / 8a7ac002f840
database/sql: Use all connections in pool
The last connection in the pool was not being handed out correctly.
R=golang-codereviews, gobot, bradfitz
CC=golang-codereviews
https://golang.org/cl/40410043
»»»
LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://golang.org/cl/68820044
Diffstat (limited to 'src/pkg/database/sql/sql_test.go')
| -rw-r--r-- | src/pkg/database/sql/sql_test.go | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/src/pkg/database/sql/sql_test.go b/src/pkg/database/sql/sql_test.go index 093c0d64ca..787a5c9f74 100644 --- a/src/pkg/database/sql/sql_test.go +++ b/src/pkg/database/sql/sql_test.go @@ -1005,6 +1005,29 @@ func TestMaxOpenConns(t *testing.T) { } } +func TestSingleOpenConn(t *testing.T) { + db := newTestDB(t, "people") + defer closeDB(t, db) + + db.SetMaxOpenConns(1) + + rows, err := db.Query("SELECT|people|name|") + if err != nil { + t.Fatal(err) + } + if err = rows.Close(); err != nil { + t.Fatal(err) + } + // shouldn't deadlock + rows, err = db.Query("SELECT|people|name|") + if err != nil { + t.Fatal(err) + } + if err = rows.Close(); err != nil { + t.Fatal(err) + } +} + // golang.org/issue/5323 func TestStmtCloseDeps(t *testing.T) { if testing.Short() { |