diff options
| author | Alex Brainman <alex.brainman@gmail.com> | 2017-04-26 14:49:58 +1000 |
|---|---|---|
| committer | Alex Brainman <alex.brainman@gmail.com> | 2017-04-26 23:17:23 +0000 |
| commit | 1989921aef60c83e6f9127a8448fb5ede10e9acc (patch) | |
| tree | ac47266b4fa02d7a9d0948b40ba100cd9fd80edd /src/path/filepath/path_windows_test.go | |
| parent | 3d86d45dd60358636c569e9cf06b23b5e0e04e8a (diff) | |
| download | go-1989921aef60c83e6f9127a8448fb5ede10e9acc.tar.xz | |
os: do not report ModeDir for symlinks on windows
When using Lstat against symlinks that point to a directory,
the function returns FileInfo with both ModeDir and ModeSymlink set.
Change that to never set ModeDir if ModeSymlink is set.
Fixes #10424
Fixes #17540
Fixes #17541
Change-Id: Iba280888aad108360b8c1f18180a24493fe7ad2b
Reviewed-on: https://go-review.googlesource.com/41830
Reviewed-by: Daniel Martà <mvdan@mvdan.cc>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Daniel Martà <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/path/filepath/path_windows_test.go')
| -rw-r--r-- | src/path/filepath/path_windows_test.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/path/filepath/path_windows_test.go b/src/path/filepath/path_windows_test.go index 0663778744..d759a83f38 100644 --- a/src/path/filepath/path_windows_test.go +++ b/src/path/filepath/path_windows_test.go @@ -451,12 +451,10 @@ func testWalkMklink(t *testing.T, linktype string) { func TestWalkDirectoryJunction(t *testing.T) { testenv.MustHaveSymlink(t) - t.Skip("skipping broken test: see issue 10424") testWalkMklink(t, "J") } func TestWalkDirectorySymlink(t *testing.T) { testenv.MustHaveSymlink(t) - t.Skip("skipping broken test: see issue 17540") testWalkMklink(t, "D") } |