diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2018-07-23 23:42:10 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2018-07-24 00:25:50 +0000 |
| commit | 416676f4d9bb2e14bce4e396c2ce67d091264751 (patch) | |
| tree | 7454e4f4563e43f7d802af790f9cd3e6df142884 /src/net/http/export_test.go | |
| parent | 240ae7e304c3fe2c22cc903964e19783f9cd6bac (diff) | |
| download | go-416676f4d9bb2e14bce4e396c2ce67d091264751.tar.xz | |
net/http: deflake TestRetryRequestsOnError
There's a 50ms threshold in net/http.Transport that this test
sometimes hitting on slower devices. That was unrelated to what this
test was trying to test. So instead just t.Skip on RoundTrip errors
unless the failure was quick (under 25ms), in which case the error
must've been about something else. Our fast machines should catch
regressions there.
Fixes #25366
Change-Id: Ibe8e2716a5b68558b57d0b8b5c46f38e46a2cba2
Reviewed-on: https://go-review.googlesource.com/125555
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/net/http/export_test.go')
| -rw-r--r-- | src/net/http/export_test.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/net/http/export_test.go b/src/net/http/export_test.go index 2c606a45a3..5ff85bc7c8 100644 --- a/src/net/http/export_test.go +++ b/src/net/http/export_test.go @@ -33,6 +33,8 @@ var ( Export_writeStatusLine = writeStatusLine ) +const MaxWriteWaitBeforeConnReuse = maxWriteWaitBeforeConnReuse + func init() { // We only want to pay for this cost during testing. // When not under test, these values are always nil |