aboutsummaryrefslogtreecommitdiff
path: root/src/make.bash
diff options
context:
space:
mode:
authorMichael Pratt <mpratt@google.com>2021-12-06 17:26:32 -0500
committerMichael Pratt <mpratt@google.com>2021-12-07 22:33:39 +0000
commit0a15e7851a0ea1ebe1523bb70a6cfe56488ea2ef (patch)
tree504afb79b608b56884a98ebfa8141a74220c0fa1 /src/make.bash
parenta3ae45ebe1b3576428f5eb27347704b2d099eab0 (diff)
downloadgo-0a15e7851a0ea1ebe1523bb70a6cfe56488ea2ef.tar.xz
runtime/pprof: assert that labelHog samples are always labeled
With https://golang.org/issue/50007 resolved, there are no known issues with pprof labels remaining. Thus, the 10% allowed error in TestLabelSystemstack should not be required. Drop it in favor of an explicit assertion that all samples containing labelHog are properly labeled. This is no flaky in my local testing. It is possible that other bugs will appear at larger testing scale, in which case this CL will be reverted, but then at least we will be aware of additional failure modes. For #50007. Change-Id: I1ef530c303bd9a01af649b8b08d4b35505e8aada Reviewed-on: https://go-review.googlesource.com/c/go/+/369744 Reviewed-by: Bryan Mills <bcmills@google.com> Trust: Michael Pratt <mpratt@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/make.bash')
0 files changed, 0 insertions, 0 deletions