diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2025-12-08 17:48:53 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-12-08 10:56:47 -0800 |
| commit | 4837bcc92c27e72c157e2c7b7e098dd91fa36fd3 (patch) | |
| tree | dea6531bf6ce7881ccca950cf80f32ea13fbf043 /src/internal/trace | |
| parent | b5f6816cea5b195e583c60e97a519d5d4ad5793f (diff) | |
| download | go-4837bcc92c27e72c157e2c7b7e098dd91fa36fd3.tar.xz | |
internal/trace: skip tests for alloc/free experiment by default
These tests are just too flaky and I don't have the time to fix them
right now. I also am thinking to just change how trace experiments work,
so it may not be worth taking the time to fix them.
For #70838.
Change-Id: Ia896215a0cbeccac99b73fefc836088f43530849
Reviewed-on: https://go-review.googlesource.com/c/go/+/728122
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/internal/trace')
| -rw-r--r-- | src/internal/trace/reader_test.go | 1 | ||||
| -rw-r--r-- | src/internal/trace/trace_test.go | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/src/internal/trace/reader_test.go b/src/internal/trace/reader_test.go index c03d0676a0..264cc51569 100644 --- a/src/internal/trace/reader_test.go +++ b/src/internal/trace/reader_test.go @@ -20,6 +20,7 @@ import ( var ( logEvents = flag.Bool("log-events", false, "whether to log high-level events; significantly slows down tests") dumpTraces = flag.Bool("dump-traces", false, "dump traces even on success") + allocFree = flag.Bool("alloc-free", false, "run alloc/free trace experiment tests") ) func TestReaderGolden(t *testing.T) { diff --git a/src/internal/trace/trace_test.go b/src/internal/trace/trace_test.go index 479411548f..bfbd531511 100644 --- a/src/internal/trace/trace_test.go +++ b/src/internal/trace/trace_test.go @@ -697,6 +697,9 @@ func testTraceProg(t *testing.T, progName string, extra func(t *testing.T, trace runTest(t, true, "") }) t.Run("AllocFree", func(t *testing.T) { + if !*allocFree { + t.Skip("skipping trace alloc/free tests by default; too flaky (see go.dev/issue/70838)") + } if testing.Short() { t.Skip("skipping trace alloc/free tests in short mode") } |