diff options
| author | Than McIntosh <thanm@google.com> | 2022-10-04 09:00:31 -0400 |
|---|---|---|
| committer | Than McIntosh <thanm@google.com> | 2022-10-04 18:08:15 +0000 |
| commit | 8bd803fd4ea3a549a9124f5a4e18af9596ef35df (patch) | |
| tree | 078970e7e27d0f3d48e0dfae4d7a5ba49bb3c01c /src/internal/testenv | |
| parent | dfd8aa461be982533e01867ab002fb83ba3cc943 (diff) | |
| download | go-8bd803fd4ea3a549a9124f5a4e18af9596ef35df.tar.xz | |
cmd/internal/sys: migrate support.go functions to new internal pkg
Separate out the functions from cmd/internal/sys/support.go and
migrate them to a new package internal/platform, so that functions such as
"RaceDetectorSupported" can be called from tests in std as well as in
cmd. This isn't a complete move of everything in cmd/internal/sys;
there are still many functions left.
The original version of this CL (patch set 1) called the new package
"internal/sys", but for packages that needed both "internal/sys" and
"cmd/internal/sys" the import of the former had to be done with a
different name, which was confusing and also required a hack in
cmd/dist.
Updates #56006.
Change-Id: I866d62e75adbf3a640a06e2c7386a6e9e2a18d91
Reviewed-on: https://go-review.googlesource.com/c/go/+/438475
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src/internal/testenv')
| -rw-r--r-- | src/internal/testenv/testenv.go | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/src/internal/testenv/testenv.go b/src/internal/testenv/testenv.go index 7b435fd002..fe34a92d9c 100644 --- a/src/internal/testenv/testenv.go +++ b/src/internal/testenv/testenv.go @@ -16,6 +16,7 @@ import ( "flag" "fmt" "internal/cfg" + "internal/platform" "os" "os/exec" "path/filepath" @@ -295,19 +296,8 @@ func MustHaveCGO(t testing.TB) { // CanInternalLink reports whether the current system can link programs with // internal linking. -// (This is the opposite of cmd/internal/sys.MustLinkExternal. Keep them in sync.) func CanInternalLink() bool { - switch runtime.GOOS { - case "android": - if runtime.GOARCH != "arm64" { - return false - } - case "ios": - if runtime.GOARCH == "arm64" { - return false - } - } - return true + return !platform.MustLinkExternal(runtime.GOOS, runtime.GOARCH) } // MustInternalLink checks that the current system can link programs with internal |