aboutsummaryrefslogtreecommitdiff
path: root/src/encoding/json/v2_stream.go
diff options
context:
space:
mode:
authorJoe Tsai <joetsai@digital-static.net>2025-07-24 17:10:54 -0700
committerGopher Robot <gobot@golang.org>2025-07-25 10:48:56 -0700
commitc76c3abc5426ab3d183514c834bcd7d6a653ae89 (patch)
treecb75706e042625e3106054505384120f39792936 /src/encoding/json/v2_stream.go
parentebdbfccd989b07a8aef75af5fbe7448f035ee239 (diff)
downloadgo-c76c3abc5426ab3d183514c834bcd7d6a653ae89.tar.xz
encoding/json: fix truncated Token error regression in goexperiment.jsonv2
The jsontext.Decoder.ReadToken method reports a non-EOF error, if the token stream is truncated and does not form a valid JSON value. In contrast, the v1 json.Decoder.Token method would report EOF so long as the input was a prefix of some valid JSON value. Modify json.Decoder.Token to preserve historical behavior. This only modifies code that is compiled in under goexperiment.jsonv2. Updates #69449 Fixes #74750 Change-Id: Ifd281c46f118f0e748076013fefc7659f77c56ed Reviewed-on: https://go-review.googlesource.com/c/go/+/689516 Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Joseph Tsai <joetsai@digital-static.net> Reviewed-by: Michael Knyszek <mknyszek@google.com>
Diffstat (limited to 'src/encoding/json/v2_stream.go')
-rw-r--r--src/encoding/json/v2_stream.go11
1 files changed, 11 insertions, 0 deletions
diff --git a/src/encoding/json/v2_stream.go b/src/encoding/json/v2_stream.go
index ccbef6077b..28e72c0a52 100644
--- a/src/encoding/json/v2_stream.go
+++ b/src/encoding/json/v2_stream.go
@@ -8,6 +8,7 @@ package json
import (
"bytes"
+ "errors"
"io"
"encoding/json/jsontext"
@@ -193,6 +194,16 @@ func (d Delim) String() string {
func (dec *Decoder) Token() (Token, error) {
tok, err := dec.dec.ReadToken()
if err != nil {
+ // Historically, v1 would report just [io.EOF] if
+ // the stream is a prefix of a valid JSON value.
+ // It reports an unwrapped [io.ErrUnexpectedEOF] if
+ // truncated within a JSON token such as a literal, number, or string.
+ if errors.Is(err, io.ErrUnexpectedEOF) {
+ if len(bytes.Trim(dec.dec.UnreadBuffer(), " \r\n\t,:")) == 0 {
+ return nil, io.EOF
+ }
+ return nil, io.ErrUnexpectedEOF
+ }
return nil, transformSyntacticError(err)
}
switch k := tok.Kind(); k {