diff options
| author | Alan Donovan <adonovan@google.com> | 2024-05-23 10:47:36 -0400 |
|---|---|---|
| committer | Alan Donovan <adonovan@google.com> | 2024-05-23 18:42:28 +0000 |
| commit | bf91eb3a8bb057a620f3823e4d6b74a529c0a44d (patch) | |
| tree | 4492b65fecf2d22336f43b63794296541d56209a /src/database/sql | |
| parent | c34c124f4007e79978674ba519b9421665060186 (diff) | |
| download | go-bf91eb3a8bb057a620f3823e4d6b74a529c0a44d.tar.xz | |
std: fix calls to Printf(s) with non-constant s
In all cases the intent was not to interpret s as a format string.
In one case (go/types), this was a latent bug in production.
(These were uncovered by a new check in vet's printf analyzer.)
Updates #60529
Change-Id: I3e17af7e589be9aec1580783a1b1011c52ec494b
Reviewed-on: https://go-review.googlesource.com/c/go/+/587855
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/database/sql')
| -rw-r--r-- | src/database/sql/sql_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/database/sql/sql_test.go b/src/database/sql/sql_test.go index 7dfc6434e0..ff65e877a5 100644 --- a/src/database/sql/sql_test.go +++ b/src/database/sql/sql_test.go @@ -1753,7 +1753,7 @@ func TestIssue6651(t *testing.T) { want := "error in rows.Next" rowsCursorNextHook = func(dest []driver.Value) error { - return fmt.Errorf(want) + return errors.New(want) } defer func() { rowsCursorNextHook = nil }() @@ -1765,7 +1765,7 @@ func TestIssue6651(t *testing.T) { want = "error in rows.Close" setRowsCloseHook(func(rows *Rows, err *error) { - *err = fmt.Errorf(want) + *err = errors.New(want) }) defer setRowsCloseHook(nil) err = db.QueryRow("SELECT|people|name|").Scan(&v) |