diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2024-03-15 22:15:37 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2024-04-10 17:23:13 +0000 |
| commit | 73981695a2518b6eae7f8ffe74d224691c60d433 (patch) | |
| tree | 2d96a3f548f44800508ceaa5f1832a39c2a257fd /src/database/sql/sql_test.go | |
| parent | 236fe24ed5e27e7b91e79f2e199b10fca13a99ba (diff) | |
| download | go-73981695a2518b6eae7f8ffe74d224691c60d433.tar.xz | |
runtime: push down systemstack requirement for tracer where possible
Currently lots of functions require systemstack because the trace buffer
might get flushed, but that will already switch to the systemstack for
the most critical bits (grabbing trace.lock). That means a lot of this
code is non-preemptible when it doesn't need to be. We've seen this
cause problems at scale, when dumping very large numbers of stacks at
once, for example.
This is a re-land of CL 572095 which was reverted in CL 577376. This
re-land includes a fix of the test that broke on the longtest builders.
Change-Id: Ia8d7cbe3aaa8398cf4a1818bac66c3415a399348
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/577377
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Diffstat (limited to 'src/database/sql/sql_test.go')
0 files changed, 0 insertions, 0 deletions