diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2022-07-07 20:01:21 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2022-07-07 21:15:48 +0000 |
| commit | 1ebc983000ed411a1c06f6b8a61770be1392e707 (patch) | |
| tree | 4f6db80ea3b089a54ee34456e2ea5a50d07656b6 /src/database/sql/sql_test.go | |
| parent | c177d9d98a7bfb21346f6309c115d0a2bf3167e3 (diff) | |
| download | go-1ebc983000ed411a1c06f6b8a61770be1392e707.tar.xz | |
runtime: overestimate the amount of allocated memory in heapLive
CL 377516 made it so that memory metrics are truly monotonic, but also
updated how heapLive tracked allocated memory to also be monotonic.
The result is that cached spans with allocated memory aren't fully
accounted for by the GC, causing it to make a worse assumption (the
exact mechanism is at this time unknown), resulting in a memory
regression, especially for smaller heaps.
This change is a partial revert of CL 377516 that makes heapLive a
non-monotonic overestimate again, which appears to resolve the
regression.
For #53738.
Change-Id: I5c51067abc0b8e0a6b89dd8dbd4a0be2e8c0c1b2
Reviewed-on: https://go-review.googlesource.com/c/go/+/416417
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/database/sql/sql_test.go')
0 files changed, 0 insertions, 0 deletions