diff options
| author | Nigel Tao <nigeltao@golang.org> | 2017-02-09 15:18:47 +1100 |
|---|---|---|
| committer | Nigel Tao <nigeltao@golang.org> | 2017-02-10 03:31:09 +0000 |
| commit | 9ef65dbe0683634a2e8a557d12267d0309ae1570 (patch) | |
| tree | aceab4c7c633d37dfe7012b8dfa034245624f32e /src/database/sql/sql.go | |
| parent | ee60d39a21f459b07cbc1550606db7ed231799e2 (diff) | |
| download | go-9ef65dbe0683634a2e8a557d12267d0309ae1570.tar.xz | |
image/gif: fix frame-inside-image bounds checking.
The semantics of the Go image.Rectangle type is that the In and
Intersects methods treat empty rectangles specially. There are multiple
valid representations of an empty image.Rectangle. One of them is the
zero image.Rectangle but there are others. They're obviously not all
equal in the == sense, so we shouldn't use != to check GIF's semantics.
This change will allow us to re-roll
a855da29dbd7a80c4d87a421c1f88a8603c020fa "image: fix the overlap check
in Rectangle.Intersect" which was rolled back in
14347ee480968c712ea885a4ea62779fd8a0dc44.
Change-Id: Ie1a0d092510a7bb6170e61adbf334b21361ff9e6
Reviewed-on: https://go-review.googlesource.com/36639
Run-TryBot: Nigel Tao <nigeltao@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Diffstat (limited to 'src/database/sql/sql.go')
0 files changed, 0 insertions, 0 deletions