diff options
| author | Nathan VanBenschoten <nvanbenschoten@gmail.com> | 2022-01-09 20:29:40 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-05-08 17:15:30 +0000 |
| commit | 831f1168289e65a7ef49942ad8d16cf14af2ef43 (patch) | |
| tree | 18672443161b3e8b37cc35eda8508bb38400537f /src/database/sql/example_cli_test.go | |
| parent | b8d55a7604aaffb9645ba1fcff9ea2c84697f7d6 (diff) | |
| download | go-831f1168289e65a7ef49942ad8d16cf14af2ef43.tar.xz | |
math/big: don't force second arg to Jacobi and Int.ModSqrt to escape
This CL updates big.Jacobi to avoid forcing its y argument to escape
to the heap. The argument was escaping because it was being passed
through an empty interface to fmt.Sprintf during an assertion failure.
As a result, callers of Jacobi and Int.ModSqrt (which calls Jacobi)
could not keep this value on the stack.
Noticed when working on https://github.com/cockroachdb/apd/pull/103.
Change-Id: I5db9ee2149bf13b921886929425861721b53b085
GitHub-Last-Rev: 3ee07b5dc3292553cc0cd0eb2d38ef036c341a9d
GitHub-Pull-Request: golang/go#50527
Reviewed-on: https://go-review.googlesource.com/c/go/+/377014
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Diffstat (limited to 'src/database/sql/example_cli_test.go')
0 files changed, 0 insertions, 0 deletions