diff options
| author | Alexander Scheel <alex.scheel@hashicorp.com> | 2022-11-03 13:09:31 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-11-03 17:40:21 +0000 |
| commit | 7abc8a2e3370bd013d9aa12b5d443e21537dfb26 (patch) | |
| tree | c5604cde76d79056d35e41f09e278d3fda5825c9 /src/crypto | |
| parent | 667c53e1599fbc61b48e3ddc95e2361b8c8fb8a5 (diff) | |
| download | go-7abc8a2e3370bd013d9aa12b5d443e21537dfb26.tar.xz | |
crypto/x509: switch test to ParseRevocationList
In following with Roland's TODO, switch TestDisableSHA1ForCertOnly to ParseRevocationList(...) over ParseCRL(...).
Change-Id: I8cdaf04ad0a1c8b94303415ae41933657067041e
GitHub-Last-Rev: bb2ef760e4fdd8c0c9228004674d4e1f581c4271
GitHub-Pull-Request: golang/go#56541
Reviewed-on: https://go-review.googlesource.com/c/go/+/447036
Reviewed-by: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Diffstat (limited to 'src/crypto')
| -rw-r--r-- | src/crypto/x509/x509_test.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/crypto/x509/x509_test.go b/src/crypto/x509/x509_test.go index 44441d45d4..0ba6d3e9fa 100644 --- a/src/crypto/x509/x509_test.go +++ b/src/crypto/x509/x509_test.go @@ -3553,13 +3553,12 @@ func TestDisableSHA1ForCertOnly(t *testing.T) { if err != nil { t.Fatalf("failed to generate test CRL: %s", err) } - // TODO(rolandshoemaker): this should be ParseRevocationList once it lands - crl, err := ParseCRL(crlDER) + crl, err := ParseRevocationList(crlDER) if err != nil { t.Fatalf("failed to parse test CRL: %s", err) } - if err = cert.CheckCRLSignature(crl); err != nil { + if err = crl.CheckSignatureFrom(cert); err != nil { t.Errorf("unexpected error: %s", err) } |