diff options
| author | Mike Faraponov <mikefaraponov@gmail.com> | 2022-04-13 12:58:29 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-08-14 00:26:03 +0000 |
| commit | 03fb5d7574eaceb26e99586dec20691663fe6b82 (patch) | |
| tree | 20c19aad436600c5092830c68e9653e221528d32 /src/crypto | |
| parent | beaa5717ba3a3e23b4f189d665e9fffb8143c0e3 (diff) | |
| download | go-03fb5d7574eaceb26e99586dec20691663fe6b82.tar.xz | |
crypto/tls: remove unused hashForClientCertificate param
Change-Id: I86af2508a31ea1e79d362c22ff4fac8900536761
GitHub-Last-Rev: d2a1ddccbd32499d7c379941daff528e7f2017c3
GitHub-Pull-Request: golang/go#52328
Reviewed-on: https://go-review.googlesource.com/c/go/+/399829
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Daniel Martà <mvdan@mvdan.cc>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Daniel Martà <mvdan@mvdan.cc>
Diffstat (limited to 'src/crypto')
| -rw-r--r-- | src/crypto/tls/handshake_client.go | 2 | ||||
| -rw-r--r-- | src/crypto/tls/handshake_server.go | 2 | ||||
| -rw-r--r-- | src/crypto/tls/prf.go | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/crypto/tls/handshake_client.go b/src/crypto/tls/handshake_client.go index f5e24cbc6d..721143cb75 100644 --- a/src/crypto/tls/handshake_client.go +++ b/src/crypto/tls/handshake_client.go @@ -629,7 +629,7 @@ func (hs *clientHandshakeState) doFullHandshake() error { } } - signed := hs.finishedHash.hashForClientCertificate(sigType, sigHash, hs.masterSecret) + signed := hs.finishedHash.hashForClientCertificate(sigType, sigHash) signOpts := crypto.SignerOpts(sigHash) if sigType == signatureRSAPSS { signOpts = &rsa.PSSOptions{SaltLength: rsa.PSSSaltLengthEqualsHash, Hash: sigHash} diff --git a/src/crypto/tls/handshake_server.go b/src/crypto/tls/handshake_server.go index 844e887af3..cf6dfad3a7 100644 --- a/src/crypto/tls/handshake_server.go +++ b/src/crypto/tls/handshake_server.go @@ -660,7 +660,7 @@ func (hs *serverHandshakeState) doFullHandshake() error { } } - signed := hs.finishedHash.hashForClientCertificate(sigType, sigHash, hs.masterSecret) + signed := hs.finishedHash.hashForClientCertificate(sigType, sigHash) if err := verifyHandshakeSignature(sigType, pub, sigHash, signed, certVerify.signature); err != nil { c.sendAlert(alertDecryptError) return errors.New("tls: invalid signature by the client certificate: " + err.Error()) diff --git a/src/crypto/tls/prf.go b/src/crypto/tls/prf.go index 13bfa009ca..b60166dee3 100644 --- a/src/crypto/tls/prf.go +++ b/src/crypto/tls/prf.go @@ -215,7 +215,7 @@ func (h finishedHash) serverSum(masterSecret []byte) []byte { // hashForClientCertificate returns the handshake messages so far, pre-hashed if // necessary, suitable for signing by a TLS client certificate. -func (h finishedHash) hashForClientCertificate(sigType uint8, hashAlg crypto.Hash, masterSecret []byte) []byte { +func (h finishedHash) hashForClientCertificate(sigType uint8, hashAlg crypto.Hash) []byte { if (h.version >= VersionTLS12 || sigType == signatureEd25519) && h.buffer == nil { panic("tls: handshake hash for a client certificate requested after discarding the handshake buffer") } |