diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2021-05-08 00:45:06 +0700 |
|---|---|---|
| committer | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2022-08-09 11:28:56 +0000 |
| commit | 0f8dffd0aa71ed996d32e77701ac5ec0bc7cde01 (patch) | |
| tree | 9840e8c7e2abac7674a9dfaa6b0c73655124f0fa /src/crypto/tls | |
| parent | 5639fcae7fee2cf04c1b87e9a81155ee3bb6ed71 (diff) | |
| download | go-0f8dffd0aa71ed996d32e77701ac5ec0bc7cde01.tar.xz | |
all: use ":" for compiler generated symbols
As it can't appear in user package paths.
There is a hack for handling "go:buildid" and "type:*" on windows/386.
Previously, windows/386 requires underscore prefix on external symbols,
but that's only applied for SHOSTOBJ/SUNDEFEXT or cgo export symbols.
"go.buildid" is STEXT, "type.*" is STYPE, thus they are not prefixed
with underscore.
In external linking mode, the external linker can't resolve them as
external symbols. But we are lucky that they have "." in their name,
so the external linker see them as Forwarder RVA exports. See:
- https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#export-address-table
- https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=ld/pe-dll.c;h=e7b82ba6ffadf74dc1b9ee71dc13d48336941e51;hb=HEAD#l972)
This CL changes "." to ":" in symbols name, so theses symbols can not be
found by external linker anymore. So a hacky way is adding the
underscore prefix for these 2 symbols. I don't have enough knowledge to
verify whether adding the underscore for all STEXT/STYPE symbols are
fine, even if it could be, that would be done in future CL.
Fixes #37762
Change-Id: I92eaaf24c0820926a36e0530fdb07b07af1fcc35
Reviewed-on: https://go-review.googlesource.com/c/go/+/317917
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/crypto/tls')
| -rw-r--r-- | src/crypto/tls/link_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/crypto/tls/link_test.go b/src/crypto/tls/link_test.go index 8c392ff7c4..454d370c88 100644 --- a/src/crypto/tls/link_test.go +++ b/src/crypto/tls/link_test.go @@ -36,8 +36,8 @@ func main() {} `, bad: []string{ "tls.(*Conn)", - "type.crypto/tls.clientHandshakeState", - "type.crypto/tls.serverHandshakeState", + "type:crypto/tls.clientHandshakeState", + "type:crypto/tls.serverHandshakeState", }, }, { |