diff options
| author | Dmitri Shuralyov <dmitshur@golang.org> | 2022-12-19 17:39:09 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-01-20 17:52:28 +0000 |
| commit | 1011ccad5cdc7a90c31f07196df0f40ba2d5f6c5 (patch) | |
| tree | 337b050a193d83cf4ad33a599ada3caa53f142fa /src/cmd | |
| parent | 399ad79fa6606c9754e2345a23536ccb15502083 (diff) | |
| download | go-1011ccad5cdc7a90c31f07196df0f40ba2d5f6c5.tar.xz | |
cmd/dist: mark linux/sparc64 as a broken port, remove incomplete map
The linux/sparc64 port is incomplete—it doesn't work, and it doesn't
have a builder. Now that dist supports broken ports, mark it as such.
The incomplete map was created to hide ports that aren't functional
from dist list output. Now that we have the broken port concept, it
seems largely redundant, so remove it for now.
For #56679.
Updates #28944.
Change-Id: I34bd23e913ed6d786a4d0aa8d2852f2b926fe4b6
Reviewed-on: https://go-review.googlesource.com/c/go/+/458516
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Diffstat (limited to 'src/cmd')
| -rw-r--r-- | src/cmd/dist/build.go | 12 | ||||
| -rw-r--r-- | src/cmd/dist/test.go | 6 |
2 files changed, 4 insertions, 14 deletions
diff --git a/src/cmd/dist/build.go b/src/cmd/dist/build.go index 96cbd3dbf6..75daf7fdbe 100644 --- a/src/cmd/dist/build.go +++ b/src/cmd/dist/build.go @@ -1681,17 +1681,13 @@ var cgoEnabled = map[string]bool{ "windows/arm64": true, } -// List of platforms which are supported but not complete yet. These get -// filtered out of cgoEnabled for 'dist list'. See go.dev/issue/28944. -var incomplete = map[string]bool{ - "linux/sparc64": true, -} - // List of platforms that are marked as broken ports. // These require -force flag to build, and also // get filtered out of cgoEnabled for 'dist list'. // See go.dev/issue/56679. -var broken = map[string]bool{} +var broken = map[string]bool{ + "linux/sparc64": true, // An incomplete port. See CL 132155. +} // List of platforms which are first class ports. See go.dev/issue/38874. var firstClass = map[string]bool{ @@ -1839,7 +1835,7 @@ func cmdlist() { var plats []string for p := range cgoEnabled { - if broken[p] || incomplete[p] { + if broken[p] { continue } plats = append(plats, p) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 5b725394e4..6eca068595 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -265,12 +265,6 @@ func (t *tester) run() { if t.failed { fmt.Println("\nFAILED") xexit(1) - } else if incomplete[goos+"/"+goarch] { - // The test succeeded, but consider it as failed so we don't - // forget to remove the port from the incomplete map once the - // port is complete. - fmt.Println("\nFAILED (incomplete port)") - xexit(1) } else if t.partial { fmt.Println("\nALL TESTS PASSED (some were excluded)") } else { |